Fix the issue reported by phpcs.

FILE: /Users/studenttrainees/New/drupalorgsite/docroot/modules/contrib/aws/README.md ------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ------------------------------------------------------------------------------------ 35 | WARNING | Line exceeds 80 characters; contains 92 characters 39 | WARNING | Line exceeds 80 characters; contains 123 characters 44 | WARNING | Line exceeds 80 characters; contains 112 characters ------------------------------------------------------------------------------------ FILE: /Users/studenttrainees/New/drupalorgsite/docroot/modules/contrib/aws/src/Traits/ProfileEntityFormTrait.php ---------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 5 | ERROR | [x] Missing trait doc comment ---------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/New/drupalorgsite/docroot/modules/contrib/aws/src/Traits/AwsServiceTrait.php --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Missing trait doc comment --------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/New/drupalorgsite/docroot/modules/contrib/aws/src/Entity/Form/ProfileForm.php ------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------- 158 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph ------------------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/New/drupalorgsite/docroot/modules/contrib/aws/src/Controller/AwsController.php ----------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------- 48 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ----------------------------------------------------------------------------------------------------------- Time: 624ms; Memory: 10MB

Comments & Activities

Issue created by @paraderojether
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update about 1 year ago
16 pass, 4 fail
@paraderojether opened merge request.
Issue was unassigned.
Status changed to Needs review about 1 year ago6:41am 5 May 2023
Comment about 1 year ago →
🇵🇭Philippines paraderojether
Created an MR to fix the issues reported by phpcs.

Please review.
Thank You.
Status changed to Needs work about 1 year ago6:47am 5 May 2023
Comment about 1 year ago →
🇮🇳India dineshkumarbollu
Hi

I reviewed MR!8 looks fine but mistakes while adding Dependency Injection

$list_builder = \Drupal::entityTypeManager()->getListBuilder('aws_profile');
$list_builder = $this->entityTypeManager->getListBuilder('aws_profile');

changing The \Drupal: to $this is not correct dependency we need to define variable $entityTypeManager and constructor
Comment about 1 year ago →
🇮🇳India arpitk
@dineshkumarbollu I don't think need to define and call it again as class AwsController extending ControllerBase. So it can be called directly. $list_builder = $this->entityTypeManager->getListBuilder('aws_profile'); looks good to me.
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update about 1 year ago
20 pass
Status changed to Needs review about 1 year ago8:55am 5 May 2023
Comment about 1 year ago →
🇮🇳India sakthi_dev
Please review.
Status changed to Fixed about 1 year ago4:06pm 8 May 2023
Comment about 1 year ago →
🇺🇸United States davisben NH
Merged!
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issue reported by phpcs.

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Comments & Activities