- Issue created by @chucksimply
- Assigned to davisben
- πΊπΈUnited States davisben NH
That isn't currently an option, but it should be fairly easy to add.
- last update
5 months ago 1 pass, 8 fail - Issue was unassigned.
- Status changed to Needs review
5 months ago 4:37pm 14 June 2024 - πΊπΈUnited States davisben NH
I think this should do it. Give it a try and see if it meets your needs.
- Status changed to RTBC
5 months ago 7:18pm 14 June 2024 - πΊπΈUnited States chucksimply
Hey @davisben... I appreciate you working on this. Patched with the merge and working perfectly! Thanks again!
- πΊπΈUnited States davisben NH
Thanks for confirming! I'll fix the tests and get it committed.
- Status changed to Needs work
4 months ago 6:43pm 8 July 2024 - πΊπΈUnited States chucksimply
The patch doesn't play nice with Webform. If you set the "Sender From Name" in a webform email, the following errors occur.
Drupal\Core\Entity\EntityStorageException: Email ""WEBFORMSENDERNAME" <support@sitename.com>" does not comply with addr-spec of RFC 2822. in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 817 of /web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).
and
Symfony\Component\Mime\Exception\RfcComplianceException: Email ""WEBFORMSENDERNAME" <support@sitename.com>" does not comply with addr-spec of RFC 2822. in Symfony\Component\Mime\Address->__construct() (line 54 of /vendor/symfony/mime/Address.php).
I'm seeing a double quote "" before the sender name, not sure if this is relevant.
- πΊπΈUnited States chucksimply
Screenshot attached showing where the sender name is set in the webform email config.
- Status changed to Needs review
4 months ago 9:50pm 2 August 2024 - πΊπΈUnited States davisben NH
I made some changes so it plays nice with Webform, or any other module that sets a from address. Could you give it another test?
- πΊπΈUnited States chucksimply
Yes, looks to be working as expected. Thanks!
-
davisben β
committed f9730d59 on 3.0.x
Resolve #3454004 "Senders name"
-
davisben β
committed f9730d59 on 3.0.x
- Status changed to Fixed
3 months ago 8:03pm 24 August 2024 -
davisben β
committed 58443a13 on 3.x
Resolve #3454004 "Senders name"
-
davisben β
committed 58443a13 on 3.x
Automatically closed - issue fixed for 2 weeks with no activity.