Layout builder does not protect against recursion

I rerolled and fixed these items:
- Core module quickedit has been removed https://www.drupal.org/node/3252839 →

In a site I am managing, patches 65 and 69 causes Paragraphs using Layout Builder in their view mode to not render their content.

I fixed some test issues here

Als @dk-massive, following the task steps and last patch I got fixed this issue.

I fixed another test issues

Fixing some another testing issues.

Fixing Cs Issue #75

Test failures.

Fixed test issue.

The last submitted patch, 79: 2979184-79.patch, failed testing. View results →

fix testing issue

fix test. adjust test to use prophesize for logger service.

trigger_error messages will have to be updated. Currently says D9

Also a change record will be needed for the new parameter in the service.

About to trigger_error message there is one a core/modules/layout_builder/src/EventSubscriber/BlockComponentRenderArray.php that is:

      @trigger_error('The logger.channel.layout_builder service must be passed to BlockComponentRenderArray::__construct(), it is required before Drupal 9.0.0.', E_USER_DEPRECATED);

As I see says "It is required before Drupal 9.0.0" I don't think is needed to change the core version to 10 in this message. D9 is still in production, also the message says "before...".

9.0.0 is no longer supported. Hasn’t been for some time.

Also can’t be made required in a minor release which this would be. So would have to be done in a major release. So if this trying to get in for 10.1 or would have to be triggered in 10.1 and required in 11

Ok, @smustgrave sounds logic.

I modified the @trigger_error message.

About "change record" for the service. I think this should be added to this list manually https://www.drupal.org/list-changes/drupal →

after or at the time that this issue merged.

Thanks but still needs a change record that will be added to the trigger_error.

Thought there was a check for it but the trigger_error follows a pattern

Example

   if ($extension_list_theme === NULL) {
      @trigger_error('Calling ' . __METHOD__ . ' without the $extension_list_theme argument is deprecated in drupal:10.1.0 and will be required in drupal:11.0.0. See https://www.drupal.org/node/3284397', E_USER_DEPRECATED);
      $extension_list_theme = \Drupal::service('extension.list.theme');
    }

Ahh, thanks @smustgrave for the guides.

I think was fixed. Pleas review.

The last submitted patch, 90: 2979184-90.patch, failed testing. View results →

Unfortunately missed the 10.1 for deprecation. If those can be updated fir 10.2 please.

The patches #90 fixed the problem for me.

Patch no longer applies to 10.3.x.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Mithun S → made their first commit to this issue’s fork.

Fixed some of the issues related to pipeline and added a commit for the same MR. Still some of the tests are getting failed, keeping the issue status as unchanged.
Thanks!!.

Last patch does not apply to 10.3. Attaching one for 10.3 (I need it).

Re-upping patch from #104 with new files included.