mmm #48 say is a patch from MR, but it isn't https://www.drupal.org/project/page_manager/issues/3362561#comment-15339088 🐛 Path has unnecessary query appended. Needs work
and now we have some enhacens from #48 that is out of current MR, needs to get compatible enhances into MR.
This patch is for 2.x branch
mm so the proposed solution is this code change
if (!preg_match('#^' . $token[2] . '$#', $mergedParams[$token[3]])) {
by
if (!preg_match('#^' . $token[2] . '$#u', $mergedParams[$token[3]])) {
I got this change works locally.
The patch #5 fails when window.performance.getEntriesByType('navigation') is empty array
This patch fixed.
Drupal 11 works with symfony/routing 6.4
Huy. @needs-review-queue-bot "It no longer applies to Drupal core"? why. can someone explain?
Debasing patch #56
Looks that with this enhance Drupal support and add all tags more than the first as a Method to Call.
Also the test runs without fail. Note that before works, but only the first tag is managed.
https://symfony.com/doc/current/service_container/tags.html#adding-addit...
Testing on d10 works
Testing fails looks unrelated... https://www.drupal.org/pift-ci-job/2823734 → some idea how to fix?
Rerrolling the patch#24 for 11.x-dev branch
This patch is only whyle migrate to 2.x branch. To get project such as is, running into D10
This patch add change to .info module to avoid compatibility issue.
Needds to review more in deep testing fail for d7 migration
Updating the side of the hook to correct place.
This patch fixes the problem.
should be close in favor of https://www.drupal.org/project/opigno_module/issues/3401907 🐛 opigno_answer__field_correct_response is short in some cases Active
After review in deep change to text (plain, long) isn't needed. Text (plain) support in my case the characters that I needed.
The solution should be change Text (plain) type for a Text (plain, long) because this field suport this kindo of content: Eau[,]Energie[,]Energie[,]Energie[,]Péage[,]Carburant[,]Telecom[,]Telecom[,]Energie[,]Carburant[,]Carburant[,]Telecom[,]Telecom where into a text is all the options, in some order. So can be more than 255
This patch removes some another uses of the function module_set_weight
patch #12 alsow works for us.
thanks for the comment @donquixote
I mean this is the Hux way to define a class:
use Drupal\hux\Attribute\Alter;
use Drupal\hux\Attribute\Hook;
use Drupal\hux\Attribute\ReplaceOriginalHook;
/**
* Usage examples.
*/
final class MyModuleHooks {
#[Hook('entity_access')]
public function myEntityAccess(EntityInterface $entity, string $operation, AccountInterface $account): AccessResultInterface {
// A barebones implementation.
return AccessResult::neutral();
}
....
Where looks that we can avoid
use Drupal\hux\Attribute\Alter;
use Drupal\hux\Attribute\Hook;
use Drupal\hux\Attribute\ReplaceOriginalHook;
extending from a parent class that already implements this.
BTW the discover looks out of drupal way for Hux class,. As you say Drupal usually define interfaces or base classes just like use Symfony EventSubscribers...
vacho → created an issue.
I am think that #[Hook('entity_access')] that Hux module provide is great to start Back Compatibility.
namespace Drupal\my_module;
use Drupal\hux\Attribute\Alter;
use Drupal\hux\Attribute\Hook;
use Drupal\hux\Attribute\ReplaceOriginalHook;
/**
* Usage examples.
*/
final class MyModuleHooks {
#[Hook('entity_access')]
public function myEntityAccess(EntityInterface $entity, string $operation, AccountInterface $account): AccessResultInterface {
// A barebones implementation.
return AccessResult::neutral();
}
However to completely POO way we need to define a Parent Class where any module that needs to implement a new "Hook", extends from this and create the new modules. also at time to extend this class we can use #... to use some existing hook, however this should be target as deprecated to provide time to core and most another modules to remove completely.
- Also we need something about weight of module into hooks system. I mean something to can get a priority order for my function with relation to another functions.
This patch fixes some issues about js-libraries paths..
I see that patch #11 doesn't works over h5p works, looks that works for a some distribution.
this patch is for h5p 2.0.0 branch
Same issue on alpha3 version.
Nice idea. I am reviewing and some notes:
- Also we need the idea to add new Implementations that should be entirely independents of the current hooks system.
- As I see hux module looks nice to convert current hooks system into a POO way. We need to alter this in order to co-exists with the current but should be prepared to works without this (current hook system).
Rebased and fixed the last code issues.
Code looks good.
Also after apply i.e "wide" this responsive style was applied to the edit form.
I added a change record. Feel free to update.
I am working on a new patch for 1.x branch. this is an advance.
- Code looks good.
- Testing locally, works!!
So RTBC
Als needs works to fix testing https://www.drupal.org/pift-ci-job/2716580 →
Patch #30 looks stable and I tested and works for my project. Please validate in deep
Also, please works over MR https://git.drupalcode.org/project/page_manager/-/merge_requests/13 to be able to take advantage of gitlab MR diffs and git log
The thing is that the core change is already in the core! #3277784
I think we need to refactor this into page_manager core as is the proposal, also WIP solutions are welcome.
About comment #11
@cilefen No, that's about "Route defaults that do not start with a leading _" turn as query parameters, Also I tested on Drupal 10, 11 and the fix in this issue with page_manager still happens, and the MR fixes.
About comment #13
@cilefen , is related yes! but it is not a regression, I mean a core code doesn't turn back. #3358402 is to fix a title issue related as you can see at MR https://git.drupalcode.org/project/drupal/-/merge_requests/3953/diffs.
@_renify_ nice to know that works for you. I think should be set as "Fixed" when is merged. So for now is "Needs review" if you can review the code, and the testing issues that pipelines returns after this you can set as "Review and Tested by comunity"
Please, review again if it was fixed for you, for my runs, also I am unsure if the test fails is related to this issue.
I found that this issue happens due to this change at the core: https://www.drupal.org/project/drupal/issues/3277784 🐛 copyRawVariables should support default route parameters Fixed
Commit: https://git.drupalcode.org/project/drupal/-/commit/a894a04bac8f2cff2339b...
Rebasing the patch #138
mmm I got updated all locally(MR7 and MR8) however I can't use the MR7. @sorlov.
Can you explain how you got this MR locally?
The following, as usual, doesn't work:
git remote add http_status_code-3250508 git@git.drupal.org:issue/http_status_code-3250508.git
git fetch http_status_code-3250508
git checkout -b '8.x-1.x' --track http_status_code-3250508/'8.x-1.x'
fatal: A branch named '8.x-1.x' already exists.
FYI still happen after apply the patch for this issue, https://www.drupal.org/project/views_autocomplete_filters/issues/3100867 ✨ Allow combining filtering fields in autocomplete results too Needs review
so is a different case.
vacho → created an issue.
Ahh, thanks @smustgrave for the guides.
I think was fixed. Pleas review.
Ok, @smustgrave sounds logic.
I modified the @trigger_error message.
About "change record" for the service. I think this should be added to this list manually https://www.drupal.org/list-changes/drupal →
after or at the time that this issue merged.
vacho → created an issue.
This was updated from 3.0.0-alpha34, so I think we need some hook_update maybe....
About to trigger_error message there is one a core/modules/layout_builder/src/EventSubscriber/BlockComponentRenderArray.php that is:
@trigger_error('The logger.channel.layout_builder service must be passed to BlockComponentRenderArray::__construct(), it is required before Drupal 9.0.0.', E_USER_DEPRECATED);
As I see says "It is required before Drupal 9.0.0" I don't think is needed to change the core version to 10 in this message. D9 is still in production, also the message says "before...".
I added to MR changes at composer.json and .info. please review.
Was fixed, please review.
Fixing some another testing issues.
I fixed another test issues
I fixed some test issues here
Als @dk-massive, following the task steps and last patch I got fixed this issue.
I rerolled and fixed these items:
- Core module quickedit has been removed
https://www.drupal.org/node/3252839 →
@Pracheth the issue is about to use the GUI button "Paste from word"
Again, I review the code and the functionality. For me, all looks good.
Working well image wit an user with a role wit permissions:
- - Use the administration pages and help
- - View the administration theme
- - Use the toolbar
Still needs to fix, test issues.
This patch is for core 8.3.x and contains array_values for SectionComponent. To avoid to crash the installation.
After review, the code and the patch #237 I saw all right.
This screen is before the patch for a role that doesn't have any Structure menu item with grant access.
This screen is after the patch.
Looks good now.
mmm for Drupal 9.3.x patch #220 not works.
The structure menu for a new role with the permissions 'Use the administration pages and help', 'View the administration theme' and 'Use the administration toolbar' still is showing.
BTW
after run:
$ drush cr
$ drush ev '\Drupal::service("router.builder")->rebuild();'the website fails
54 07/May 17:54 error php TypeError: Argument 2 passed to Symfony\Component\Routing\RouteCollection::add() must be an instance of Symfony\Component\Routing\Route, bool given, called in /var/www/html/contribdrupal9/
55 07/May 17:54 warning php Warning: Erroneous data format for unserializing 'Symfony\Component\Routing\Route' in Drupal\Core\Routing\RouteProvider->getRoutesByPath() (line 380 of /var/www/html/contribdrupal9/core/li