Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org ā†’
Created on 21 September 2023, 9 months ago
Updated 13 June 2024, 15 days ago

Problem/Motivation

There are some code issues about php-drupal standars:


FILE: ...enerator/migrate_generator_export/src/Commands/DrushCommands.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 235 | WARNING | Line exceeds 80 characters; contains 84 characters
     |         | (Drupal.Files.LineLength.TooLong)
----------------------------------------------------------------------


FILE: ...ules/migrate_generator/src/Plugin/migrate/process/IpToBinary.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 10 | ERROR | Missing short description in doc comment
    |       | (Drupal.Commenting.DocComment.MissingShort)
----------------------------------------------------------------------
šŸ“Œ Task
Status

Fixed

Version

2.0

Component

Code

Created by

šŸ‡§šŸ‡“Bolivia vacho Cochabamba

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @vacho
  • Merge request !8Issue #3388895: Fix the issues reported by phpcs ā†’ (Merged) created by vacho
  • Status changed to Needs review 9 months ago
  • Comment 9 months ago ā†’
    šŸ‡§šŸ‡“Bolivia vacho Cochabamba
  • Status changed to Needs work 9 months ago
  • Comment 9 months ago ā†’
    šŸ‡µšŸ‡­Philippines clarkssquared

    Hi vacho,

    I applied your MR !8 and there are still many PHPCS issues being flagged in my terminal, there are also many PHPCS issues that are not mentioned in the description, for your reference below is the errors being flagged even after I applied MR !8.

     contrib git:(master) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml migrate_generator 

FILE: ...ubing/Projects/d9/d9-local/web/modules/contrib/migrate_generator/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 29 WARNINGS AFFECTING 29 LINES
--------------------------------------------------------------------------------
   6 | WARNING | Line exceeds 80 characters; contains 91 characters
  13 | WARNING | Line exceeds 80 characters; contains 127 characters
  31 | WARNING | Line exceeds 80 characters; contains 101 characters
  32 | WARNING | Line exceeds 80 characters; contains 81 characters
  37 | WARNING | Line exceeds 80 characters; contains 110 characters
  39 | WARNING | Line exceeds 80 characters; contains 137 characters
  44 | WARNING | Line exceeds 80 characters; contains 149 characters
  50 | WARNING | Line exceeds 80 characters; contains 82 characters
  59 | WARNING | Line exceeds 80 characters; contains 131 characters
  67 | WARNING | Line exceeds 80 characters; contains 94 characters
  72 | WARNING | Line exceeds 80 characters; contains 81 characters
  73 | WARNING | Line exceeds 80 characters; contains 81 characters
  75 | WARNING | Line exceeds 80 characters; contains 117 characters
  78 | WARNING | Line exceeds 80 characters; contains 95 characters
  88 | WARNING | Line exceeds 80 characters; contains 83 characters
  92 | WARNING | Line exceeds 80 characters; contains 87 characters
  94 | WARNING | Line exceeds 80 characters; contains 124 characters
  96 | WARNING | Line exceeds 80 characters; contains 85 characters
 102 | WARNING | Line exceeds 80 characters; contains 103 characters
 106 | WARNING | Line exceeds 80 characters; contains 91 characters
 108 | WARNING | Line exceeds 80 characters; contains 89 characters
 110 | WARNING | Line exceeds 80 characters; contains 148 characters
 125 | WARNING | Line exceeds 80 characters; contains 90 characters
 126 | WARNING | Line exceeds 80 characters; contains 100 characters
 129 | WARNING | Line exceeds 80 characters; contains 87 characters
 135 | WARNING | Line exceeds 80 characters; contains 121 characters
 139 | WARNING | Line exceeds 80 characters; contains 95 characters
 140 | WARNING | Line exceeds 80 characters; contains 95 characters
 147 | WARNING | Line exceeds 80 characters; contains 148 characters
--------------------------------------------------------------------------------


FILE: ...l/web/modules/contrib/migrate_generator/migrate_generator_export/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------
 11 | WARNING | Line exceeds 80 characters; contains 82 characters
 13 | WARNING | Line exceeds 80 characters; contains 112 characters
 14 | WARNING | Line exceeds 80 characters; contains 89 characters
 18 | WARNING | Line exceeds 80 characters; contains 106 characters
 26 | WARNING | Line exceeds 80 characters; contains 156 characters
 31 | WARNING | Line exceeds 80 characters; contains 85 characters
 36 | WARNING | Line exceeds 80 characters; contains 93 characters
 41 | WARNING | Line exceeds 80 characters; contains 121 characters
 46 | WARNING | Line exceeds 80 characters; contains 93 characters
 49 | WARNING | Line exceeds 80 characters; contains 86 characters
--------------------------------------------------------------------------------


FILE: ...generator/migrate_generator_export/src/Form/EntityTypeExportConfigForm.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
 116 | ERROR | The array declaration extends to column 82 (the limit is 80).
     |       | The array content should be split up over multiple lines
 117 | ERROR | The array declaration extends to column 115 (the limit is 80).
     |       | The array content should be split up over multiple lines
 118 | ERROR | The array declaration extends to column 126 (the limit is 80).
     |       | The array content should be split up over multiple lines
 170 | ERROR | The array declaration extends to column 142 (the limit is 80).
     |       | The array content should be split up over multiple lines
 217 | ERROR | The array declaration extends to column 131 (the limit is 80).
     |       | The array content should be split up over multiple lines
--------------------------------------------------------------------------------


FILE: ...contrib/migrate_generator/migrate_generator_export/src/Form/ExportForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 201 | ERROR | [x] list(...) is forbidden, use [...] instead.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...s/contrib/migrate_generator/migrate_generator_export/src/ExportManager.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
  85 | ERROR | [x] list(...) is forbidden, use [...] instead.
 107 | ERROR | [ ] The array declaration extends to column 107 (the limit is
     |       |     80). The array content should be split up over multiple
     |       |     lines
 252 | ERROR | [ ] The array declaration extends to column 108 (the limit is
     |       |     80). The array content should be split up over multiple
     |       |     lines
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...te_generator/migrate_generator_export/src/GeneratorExportPluginManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is
   |       |     Drupal\Component\Plugin\FallbackPluginManagerInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...tor/migrate_generator_export/src/Plugin/GeneratorExportPluginInterface.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is
   |       |     Drupal\Component\Plugin\PluginInspectionInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ator/migrate_generator_export/src/Plugin/GeneratorExportPluginDateBase.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 31 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...enerator_export/src/Plugin/migrate_generator_export/process/FileExport.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 63 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: .../migrate_generator/migrate_generator_export/src/Commands/DrushCommands.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 206 | ERROR | [x] list(...) is forbidden, use [...] instead.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...rib/migrate_generator/migrate_generator_export/src/FieldsExportManager.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
  6 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is
    |       |     Drupal\Component\Plugin\Exception\PluginNotFoundException.
 59 | ERROR | [x] list(...) is forbidden, use [...] instead.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...es/contrib/migrate_generator/src/Plugin/GeneratorProcessPluginDateBase.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 50 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...odules/contrib/migrate_generator/src/Plugin/GeneratorProcessPluginBase.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
  8 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Psr\Log\LoggerInterface.
 97 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...eb/modules/contrib/migrate_generator/src/GeneratorProcessPluginManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is
   |       |     Drupal\Component\Plugin\FallbackPluginManagerInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...Projects/d9/d9-local/web/modules/contrib/migrate_generator/src/Scanner.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\Core\Entity\EntityFieldManager.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...local/web/modules/contrib/migrate_generator/src/Commands/DrushCommands.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\migrate_generator\Scanner.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ojects/d9/d9-local/web/modules/contrib/migrate_generator/src/Generator.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\migrate_plus\Entity\Migration.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 933ms; Memory: 14MB
  • Assigned to Mohd Sahzad
  • Comment 9 months ago ā†’
    šŸ‡®šŸ‡³India Mohd Sahzad
  • Issue was unassigned.
  • Comment 9 months ago ā†’
    šŸ‡®šŸ‡³India Mohd Sahzad

    I have fixed this Fix the issues reported by phpcs please review this patch

  • Comment 9 months ago ā†’
    šŸ‡®šŸ‡³India nitin_lama

    @mohd-sahzad Please update the status to Needs Review when you want someone to review your patch.

  • Status changed to Needs review 9 months ago
  • Comment 9 months ago ā†’
    šŸ‡®šŸ‡³India nitin_lama
  • Comment 9 months ago ā†’
    šŸ‡®šŸ‡³India nitin_lama

    I have tried to apply the patch on the MR branch, but patch is not applied. Moving to NW status.

  • Assigned to nitin_lama
  • Status changed to Needs work 9 months ago
  • Comment 9 months ago ā†’
    šŸ‡®šŸ‡³India nitin_lama
  • Issue was unassigned.
  • Status changed to Needs review 9 months ago
  • Comment 9 months ago ā†’
    šŸ‡®šŸ‡³India nitin_lama

    Please review.

  • Status changed to Needs work 9 months ago
  • Comment 9 months ago ā†’
    šŸ‡µšŸ‡­Philippines clarkssquared

    Hi,

    I applied the updated MR !8 in my local and I can still see many PHPCS issues being flagged, for convenience, below are the issues according to my terminal.

    FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/migrate_generator/README.md
----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------
 119 | WARNING | Line exceeds 80 characters; contains 103 characters
 126 | WARNING | Line exceeds 80 characters; contains 89 characters
----------------------------------------------------------------------------------------------------


FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/migrate_generator/migrate_generator_export/src/GeneratorExportPluginManager.php
--------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Plugin\FallbackPluginManagerInterface.
--------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/migrate_generator/migrate_generator_export/src/Plugin/GeneratorExportPluginInterface.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Plugin\PluginInspectionInterface.
-----------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/migrate_generator/migrate_generator_export/src/FieldsExportManager.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Plugin\Exception\PluginNotFoundException.
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/migrate_generator/src/Plugin/GeneratorProcessPluginBase.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Psr\Log\LoggerInterface.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/migrate_generator/src/GeneratorProcessPluginManager.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Plugin\FallbackPluginManagerInterface.
------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/migrate_generator/src/Scanner.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityFieldManager.
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/migrate_generator/src/Commands/DrushCommands.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate_generator\Scanner.
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------


FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/migrate_generator/src/Generator.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate_plus\Entity\Migration.
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------

Time: 1 secs; Memory: 12MB

    moving this to needs work,
    thanks.

  • Status changed to Needs review 9 months ago
  • Comment 9 months ago ā†’
    šŸ‡®šŸ‡³India aayushDrupal

    Hi,
    I have fixed all the remaining phpcs errors mentioned in comment #12 in this patch.
    Please review.

  • Assigned to nitin_lama
  • Status changed to Needs work 9 months ago
  • Comment 9 months ago ā†’
    šŸ‡®šŸ‡³India nitin_lama
  • Issue was unassigned.
  • Status changed to Needs review 9 months ago
  • Comment 9 months ago ā†’
    šŸ‡®šŸ‡³India nitin_lama
  • Status changed to Needs work 8 months ago
  • Comment 8 months ago ā†’
    šŸ‡·šŸ‡ŗRussia sorlov

    Need to rebase branch with latest changes in 8.x-2.x

  • First commit to issue fork.
  • Status changed to Needs review 7 months ago
  • Comment 7 months ago ā†’
    šŸ‡·šŸ‡ŗRussia sorlov

    rebased to latest 8.x-2.x version

  • Status changed to Needs work 7 months ago
  • Comment 7 months ago ā†’
    šŸ‡µšŸ‡­Philippines clarkssquared

    Hi

    I applied the MR !8 after commit #!7 and I can still many PHPCS issues being flagged in my terminal, for your reference this is the output from my terminal

    āžœ  migrate_generator git:(8.x-2.2) curl https://git.drupalcode.org/project/migrate_generator/-/merge_requests/8.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 26990    0 26990    0     0  43253      0 --:--:-- --:--:-- --:--:-- 44173
patching file README.md
patching file 'migrate_generator_export/README.md'
patching file 'migrate_generator_export/src/Commands/DrushCommands.php'
patching file 'migrate_generator_export/src/ExportManager.php'
patching file 'migrate_generator_export/src/FieldsExportManager.php'
patching file 'migrate_generator_export/src/Form/EntityTypeExportConfigForm.php'
patching file 'migrate_generator_export/src/Form/ExportForm.php'
patching file 'migrate_generator_export/src/GeneratorExportPluginManager.php'
patching file 'migrate_generator_export/src/Plugin/GeneratorExportPluginDateBase.php'
patching file 'migrate_generator_export/src/Plugin/GeneratorExportPluginInterface.php'
patching file 'migrate_generator_export/src/Plugin/migrate_generator_export/process/FileExport.php'
patching file 'src/Commands/DrushCommands.php'
patching file 'src/GeneratorProcessPluginManager.php'
patching file 'src/Plugin/GeneratorProcessPluginBase.php'
patching file 'src/Plugin/GeneratorProcessPluginDateBase.php'
patching file 'src/Scanner.php'
āžœ  migrate_generator git:(8.x-2.2) āœ— ..
āžœ  contrib git:(master) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml migrate_generator

FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/migrate_generator/migrate_generator.post_update.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------
  9 | ERROR | [ ] Doc comment short description must start with a capital letter
  9 | ERROR | [x] Doc comment star missing
 10 | ERROR | [ ] Doc comment short description must end with a full stop
 10 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/migrate_generator/README.md
----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
 123 | WARNING | Line exceeds 80 characters; contains 100 characters
----------------------------------------------------------------------------------------------------


FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/migrate_generator/migrate_generator_export/migrate_generator_export.links.task.yml
-----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/migrate_generator/migrate_generator_export/README.md
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES
-----------------------------------------------------------------------------------------------------------------------------
  6 | WARNING | Line exceeds 80 characters; contains 129 characters
 11 | WARNING | Line exceeds 80 characters; contains 108 characters
 13 | WARNING | Line exceeds 80 characters; contains 93 characters
 15 | WARNING | Line exceeds 80 characters; contains 82 characters
 21 | WARNING | Line exceeds 80 characters; contains 106 characters
 27 | WARNING | Line exceeds 80 characters; contains 84 characters
 28 | WARNING | Line exceeds 80 characters; contains 114 characters
 29 | WARNING | Line exceeds 80 characters; contains 266 characters
 31 | WARNING | Line exceeds 80 characters; contains 94 characters
 46 | WARNING | Line exceeds 80 characters; contains 92 characters
 64 | WARNING | Line exceeds 80 characters; contains 92 characters
-----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/migrate_generator/migrate_generator_export/src/ExportManager.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
 288 | ERROR | [x] Expected 1 space after comma in argument list; 2 found
 288 | ERROR | [x] Expected one space after the comma, 2 found
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------

Time: 1.16 secs; Memory: 14MB

āžœ  contrib git:(master) āœ—
  • First commit to issue fork.
  • Status changed to Needs review 7 months ago
  • Comment 7 months ago ā†’
    šŸ‡®šŸ‡³India sourabhjain

    Fixed the issues mentioned in #19. Please review.

  • Comment about 1 month ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Status changed to RTBC about 1 month ago
  • Comment about 1 month ago ā†’
    šŸ‡µšŸ‡­Philippines paraderojether

    Hi

    I reviewed MR!8, applied against Migrate Generator 8.x-2.x-dev, and confirmed fixes the issues reported by phpcs. 

    migrate_generator git:(8.x-2.2) curl https://git.drupalcode.org/project/migrate_generator/-/merge_requests/8.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 33546    0 33546    0     0  78327      0 --:--:-- --:--:-- --:--:-- 79681
patching file README.md
patching file migrate_generator.post_update.php
patching file 'migrate_generator_export/README.md'
patching file 'migrate_generator_export/migrate_generator_export.links.task.yml'
patching file 'migrate_generator_export/src/Commands/DrushCommands.php'
patching file 'migrate_generator_export/src/ExportManager.php'
patching file 'migrate_generator_export/src/FieldsExportManager.php'
patching file 'migrate_generator_export/src/Form/EntityTypeExportConfigForm.php'
patching file 'migrate_generator_export/src/Form/ExportForm.php'
patching file 'migrate_generator_export/src/GeneratorExportPluginManager.php'
patching file 'migrate_generator_export/src/Plugin/GeneratorExportPluginDateBase.php'
patching file 'migrate_generator_export/src/Plugin/GeneratorExportPluginInterface.php'
patching file 'migrate_generator_export/src/Plugin/migrate_generator_export/process/FileExport.php'
patching file 'src/Commands/DrushCommands.php'
patching file 'src/GeneratorProcessPluginManager.php'
patching file 'src/Plugin/GeneratorProcessPluginBase.php'
patching file 'src/Plugin/GeneratorProcessPluginDateBase.php'
patching file 'src/Scanner.php'
āžœ  migrate_generator git:(8.x-2.2) āœ— cd ..
āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig migrate_generator
āžœ  contrib git:(main) āœ—

    Thank you.

  • Comment 29 days ago ā†’
    System Message
  • Status changed to Fixed 29 days ago
  • Comment 29 days ago ā†’
    šŸ‡·šŸ‡ŗRussia sorlov

    Great, thanks everybody

  • Comment 29 days ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    apaderno ā†’ changed the visibility of the branch 8.x-1.x to hidden.

  • Comment 29 days ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    apaderno ā†’ changed the visibility of the branch 8.x-2.x to hidden.

  • Comment 15 days ago ā†’
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024