🇷🇺Russia @sorlov

also have fixed some issues with config settings schemas

sorlov → created an issue.

sorlov → created an issue.

sorlov → made their first commit to this issue’s fork.

Fixed tests

Fixed "View more" link to be in separate column, tests should be fine now

Test failed on createUserWithRegcode() because of broken unlimited (0) maxuses value for regcode.

I've fixed that and now we have another issue with testViewRegisteredUsersWithRegcode test (about showing users list in popup from View more link

sorlov → made their first commit to this issue’s fork.

sorlov → made their first commit to this issue’s fork.

created new MR for 2.0.x branch https://git.drupalcode.org/project/regcode/-/merge_requests/15 and pushed changes there

I'm not sure if this is global issue, related to any item element, cause for example, we have a lot of item elements in FileSystemForm form, but they are not exposed to config values

Added assertion to EntityCloneEntityTypeSettingsTest but now got it failed

rebased again and fixed phpcs error

but we still have failed tests (btw unsure why do we have some changes in tests assertions in MR)

Opened separate MR https://git.drupalcode.org/project/drupal/-/merge_requests/9250 for another solution

Issue was fixed by adding '#input' => FALSE, to $form['time_diff']['description']

So now we won't have empty description key in formatter config

This issue can be easily fixed when you use '#input' => FALSE, for your item element

Unsure if we need such global form API changes

Maybe better work on it from Item render element

sorlov → made their first commit to this issue’s fork.

currently we have next definition in ctools.schema.yml

ctools.block_plugin.*:
  type: block.settings.[id]
  mapping:
    region:
      type: string
      label: 'Region'
    weight:
      type: integer
      label: 'Weight'
    uuid:
      type: string
      label: 'UUID'
    context_mapping:
      type: sequence
      label: 'Context assignments'
      sequence:
        type: string

No errors after using patch

@ilya.no issue can happen not only for views_block schema, but for other blocks as well

sorlov → created an issue.

rebased from latest 11.x

Got the similar issue with panels_everywhere_variant display variant

system_branding_block is used there and config schema seems to be ok for this block in system.schema.yml:

block.settings.system_branding_block:
  type: block_settings
  label: 'Branding block'
  constraints:
    FullyValidatable: ~
  mapping:
    use_site_logo:
      type: boolean
      label: 'Use site logo'
    use_site_name:
      type: boolean
      label: 'Use site name'
    use_site_slogan:
      type: boolean
      label: 'Use site slogan'

but looks like ctools.block_plugin.* schema doesn't inherit it

sorlov → created an issue.

rebased branch from latest 8.x-1.x, so now MR can be merged

sorlov → made their first commit to this issue’s fork.

Added hook_post_update_NAME() to update existing views with description for time_diff for timestamp formatter

need review

Added hook_post_update_NAME() to update structure of settings for related filters in existing configs, Plz, review

Refactored config schema for module. It makes no sense to have different schema files for each filter plugin.

Apply patch and update text format - configuration has a new structure/values

Then maybe we should provide hook_post_update to update existing formats that use these filters with new structure?

Still got this issue with panels_variant display variant used

"ctools.block_plugin" doesn't inherit from "block.settings.views_block:*"

sorlov → created an issue.

These issues seems to be fixed already in https://www.drupal.org/i/3410270 →

sorlov → made their first commit to this issue’s fork.

I can see that some types were updated but not sure if these changes are correct

sorlov → made their first commit to this issue’s fork.

Great, thanks everybody

updated issue summary

Created draft MR from patch from #2

For mentioned pattern_settings and variants_token settings, I guess we need to wait till https://www.drupal.org/project/ui_patterns/issues/3336970 📌 [2.0.0-alpha3] Fix config schema Needs work will be resolved

updated $title

sorlov → created an issue.

renamed

sorlov → created an issue. See original summary → .

Made suggested improvements

previously, ViewsRow annotation extends ViewsPluginAnnotationBase, not ViewsHandlerAnnotationBase

so we don't need to use PluginID here

@mstrelan where do we have a mix of both double and single quotes?

sorlov → made their first commit to this issue’s fork.

sorlov → made their first commit to this issue’s fork.

sorlov → made their first commit to this issue’s fork.

sorlov → made their first commit to this issue’s fork.

sorlov → made their first commit to this issue’s fork.

sorlov → made their first commit to this issue’s fork.

sorlov → made their first commit to this issue’s fork.

sorlov → made their first commit to this issue’s fork.

sorlov → made their first commit to this issue’s fork.

sorlov → made their first commit to this issue’s fork.