- Merge request !2Issue #3227669: Display all users which used the current regcode. → (Open) created by artemboiko
- 🇷🇺Russia ilya.no
I think, that we can ignore the patch from comment #25, because it adds changes from #3227667 → issue, so one can use one patch for implementing both features.
Attaching interdiff. - 🇺🇸United States SocialNicheGuru
Could the new regcode_user table have a primary key?
I ran into this issue:
MYSQL READ-COMMITTED
For this to work correctly, all tables must have a primary key. The following table(s) do not have a primary key: regcode_users. See the setting MySQL transaction isolation level page for more information.Drupal 9.5.8
php8.1 - First commit to issue fork.
- Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - last update
about 1 year ago 1 pass - Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7last update
9 months ago Waiting for branch to pass - Status changed to Needs work
2 months ago 12:26am 5 September 2024 - 🇺🇸United States tr Cascadia
The MR doesn't apply any longer, and is going to need manual rebasing. As long as that has to be done, lets do it for the current 2.0.x branch. This will require a new MR most likely.
- Status changed to Needs review
2 months ago 5:18am 9 September 2024 - 🇷🇺Russia sorlov
created new MR for 2.0.x branch https://git.drupalcode.org/project/regcode/-/merge_requests/15 and pushed changes there
- 🇺🇸United States tr Cascadia
That fixed all the coding standards, but the test is still failing.
I would still also like a test for the hook_update_N().
- 🇷🇺Russia sorlov
Test failed on createUserWithRegcode() because of broken unlimited (0) maxuses value for regcode.
I've fixed that and now we have another issue with testViewRegisteredUsersWithRegcode test (about showing users list in popup from View more link
- 🇷🇺Russia sorlov
Fixed "View more" link to be in separate column, tests should be fine now