Lviv
Account created on 2 August 2011, over 13 years ago
#

Merge Requests

More

Recent comments

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

@tobas1996 thanx,

Good catch, my miss to add "span class".
I agree regarding hardcoded basic_html need to find a way for getting this right dynamically.

I am not sure about generating css because this is fornt part and could be different theme on front, need to think about this too.

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

Aha got it, makes sense.
Thanx for info @akalam

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

Ok @akalam thanx, btw you can use patch from MR in gitlab :)

We have a link to the patch in Code > Download > Patches > https://git.drupalcode.org/project/entityqueue/-/merge_requests/20.patch

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

@yovanny.gomez.oyola

Is your filter on the top of Filter processing order ?

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

Did you enable Convert color styles to class filter in text format filters list? I guess this should add ability to save rich text to db with hsl styles, and then on edit page in ckeditor you will see colors

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

artemboiko β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

Hi all,

Created MR5 with the implementation of CKEditor filter plugin for rewriting styles color to color classes. Unfortunately, it should work only with basic_html. Need to find a way how to improve this...

Another point Convert color styles to class plugin should be upper than Limit allowed HTML tags and correct faulty HTML on text format settings page admin/config/content/formats/manage/basic_html (need to add this readme I guess)

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

Tested MR #5583 on Drupal 10.2.1 looks fine, thanx

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

artemboiko β†’ changed the visibility of the branch 2546212-entity-viewform-mode to hidden.

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

Hi @martijn-de-wit I guess need show this branch as a branch for 10.2.x, but also I think it will be better to rename branch with 10.2.x in name for better visibility and yep create new mr with patch 269 from @manojbisht_drupal

What you think about this next steps?

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

artemboiko β†’ changed the visibility of the branch 2546212-entity-viewform-mode to active.

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

@mahde, thanx.

Looks like patch 128 works fine for 10.2.1

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

@rang501 ok I have created another MR for 2.1.x, and I will test with this version later

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

@simonbaese nice, I checked on my app, all works good.

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

Hi @simonbaese let's imagine we have few blocks with different templates and styles for different levels.

Fore example, first level of menu is horizontal block from left to right with full width of page
And second level of menu should be printed on the left sidebar just a list of link from up to down.

Example Layout:
Header
First level menu item 1 - First level menu item 2 - First level menu item 3 - ...
Left sidebar
Second Level menu item 1
Second Level menu item 2
...

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

Let's finally add this cool feature to the module. It is really helpfull. Used patches from this issue in a lot of projects :)

Also, I like descriptions to the options this is very informative.

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

Updated patch from #11 by @mounir_abid

Corrected paths to files and name.

I didn't test deep. But webprofiler shows that queries to key value table disappear.

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

Hi @Matthijs yes, right getLocale not good here I changed it to LanguageManager, also I don't see any reason to use custom language negotiator in module so I removed. This is breaking all logic regarding localisation. With this patch user should add redirect_uri per language(and I guess need not to loose add this to documentation) like these:

en/oidc/login-redirect
de/oidc/login-redirect

And if user want to use one redirect uri need to write custom language negotiator with special logic.

πŸ‡ΊπŸ‡¦Ukraine artemboiko Lviv

Caught the same problem, thanx for saving time.)

Production build 0.71.5 2024