- Issue created by @artemboiko
- Merge request !20Added new permissions for enable/disable entityqueue, fixed bug with configure... β (Open) created by artemboiko
- last update
about 1 year ago 4 pass - Status changed to Needs review
about 1 year ago 4:07pm 23 October 2023 - First commit to issue fork.
- last update
10 months ago 4 pass - πͺπΈSpain akalam
Thanks for the MR @artemboiko! I'm still seeing the links for the operations which the user don't have access on the "Entity Queue" tab on entities, so I'm adding a new commit to fix it.
In the commit I'm checking the access to the url instead of checking the access to the entity operation. That's because the access could had been extended by other modules (like the group_entityqueue for example or custom access requirements) and by checking the access to the url will work properly on all scenarios. - last update
10 months ago 4 pass - πΊπ¦Ukraine artemboiko Lviv
Ok @akalam thanx, btw you can use patch from MR in gitlab :)
We have a link to the patch in Code > Download > Patches > https://git.drupalcode.org/project/entityqueue/-/merge_requests/20.patch
- πͺπΈSpain akalam
Hi @artemboiko the problem with patches from MR is that they are dynamic, they are generated automatically from the MR and the MR can change at anytime. It can lead on your site being deployed introducing untested code, or even the patch not applying without prior notification. There's a big discussion on this topic on the following issues: π GitLab Merge Requests Unable to Generate Incremental Patch Files Active and #2488266: [META] Improve Git workflow on Drupal.org by implementing issue workspaces β
- πΊπ¦Ukraine artemboiko Lviv
Aha got it, makes sense.
Thanx for info @akalam - Status changed to Postponed: needs info
7 months ago 8:55am 31 May 2024 - π·π΄Romania amateescu
I've moved @akalam's commit into a separate issue: π Display only the operations the user has access to in subqueueListForEntity Fixed
@artemboiko, can you please write some steps to reproduce for this part?
we have a bug with configure user don't have access to this page but still can see link on entityqueue list page
Also, what's the use case for a separate enable/disable permission? Is the general "update" permission not sufficient?