- Issue created by @heddn
- First commit to issue fork.
- Merge request !5505Issue #3400522 by Boobaa: TimestampFormatter / time_diff missing config schema β (Open) created by Boobaa
- Status changed to Needs review
7 months ago 12:58pm 22 November 2023 - Status changed to Needs work
7 months ago 2:04pm 22 November 2023 - πΊπΈUnited States smustgrave
Can the rest of the issue summary be filled in please.
Also change caused test failures.
- heddn Nicaragua
Obviously we need tests added or this wouldn't have passed any if there were any. Tagging.
- πΊπΈUnited States agentrickard Georgia (US)
Here's a simple view that shows the issue -- let me see if I can work up an MR.
- Status changed to Needs review
5 months ago 5:55pm 10 February 2024 - πΊπΈUnited States agentrickard Georgia (US)
OK, here's what I did.
- Added that view as
core/modules/node/tests/modules/node_test_views/test_views/views.view.test_field_created.yml
- Reverted the schema commit
If I read the code from
core/modules/node/tests/src/Functional/Views/NodeTestBase.php
, the setup() method should try to import the new view and then auto-fail schema checks. - Added that view as
- Status changed to Needs work
5 months ago 6:23pm 10 February 2024 - πΊπΈUnited States smustgrave
There's a test-only feature so don't need to push separately.
- πΊπΈUnited States agentrickard Georgia (US)
Well, I suspect this minor issue may be covering up a more major problem (which we should file separately).
This is the YML from the test file:
time_diff: enabled: false future_format: '@interval hence' past_format: '@interval ago' granularity: 2 refresh: 60 description: ''
This is the YML from core views.view_content
time_diff: enabled: false future_format: '@interval hence' past_format: '@interval ago' granularity: 2 refresh: 60
When the schema change was made in core, the affected core views were not updated. The following core views are potentially affected:
- views.view.media.yml
- views.view.test_content_ajax.yml
- views.view.test_field_created.yml
- views.view.glossary.yml
- views.view.content.yml
- views.view.media_library.yml
- views.view.media.yml
- views.view.files.yml
- views.view.moderated_content.yml
- views.view.comment.yml
- views.view.block_content.yml
- core.entity_view_display.media.type_five.default.yml
- core.entity_view_display.media.type_two.default.yml
- core.entity_view_display.media.type_three.default.yml
- core.entity_view_display.media.type_one.default.yml
What does this potentially mean?
- Core is not updating its views consistently -- for both distribution and tests -- this seems like a process issue
- Views only updates yml elements when the plugin usage is added (not edited, so far as I can tell)
If the affected core views had been updated with the original change was made, tests would have caught the issue.
- Status changed to Needs review
5 months ago 4:50pm 11 February 2024 - πΊπΈUnited States agentrickard Georgia (US)
Here's an updated MR that does the following:
* Removes the new test file
* Adds the `description` element to `views.view.content.yml` - πΊπΈUnited States agentrickard Georgia (US)
Update:
* This merge shows the issue (and the test fails) https://git.drupalcode.org/project/drupal/-/merge_requests/5505/diffs?co...
* Re-added the original patch / change
* Updated all affected views - Status changed to Needs work
4 months ago 3:44pm 15 February 2024 - πΊπΈUnited States smustgrave
Seems to have failures
But if we are updating all views will need an upgrade path for existing sites
Also not sure the title reflects what the MR is doing so tagged for that.
- π©πͺGermany Anybody Porta Westfalica
Confirming this issue, we just ran into it. Resaving the view adds the empty string.
- First commit to issue fork.