Convert MediaSource plugin discovery to attributes

Seems to have a check failure

Fixed phpstan issue

Left some comments on the MR.

Still need to fix the forms key

Appears feedback has been addressed

Think there is a syntax error in the example.

Good catch! Appears typo has been resolved

I've left some review comments on the MR - it looks as though we have some incorrect information in the docs and maybe some unused parameters - can someone open the requested follow-ups and also make the suggested improvements to the MR. Thanks!

Made suggested improvements

I reviewed the unresolved threads and found that they have been resolved. The last three were for followups, which I have just created. All tests are passing, so I am setting to NR.

This is on hold. The work is being done in 📌 Update MigratePluginManager to include both attribute and annotation class Fixed

Sorry for the noise, this is the wrong issue.

Feedback/follow ups seem to be addressed

Searched again for @MediaSource all instances appear to be replaced.

Believe this one is good to go.

I think we need to discuss the providers key. I don't think it should be on the MediaSource attribute it is only meaningful for the oembed plugin and it is set in the dervier anyway - so I think that means we don't need it in the attribute. It would be good to look at how any module providing an ombed integration is doing it.

If they follow the example in \Drupal\media\Plugin\media\Source\OEmbed then it will work because that is telling them to do a example_media_source_info_alter

I made the suggested changes but this still needs discussion of that idea.

Appears feedback has been addressed.

Sure we would of seen it in tests but made sure that remote embeds still work when using the MR.

Seems very strange to me to have a plugin definition key that only a specific implementation (and its derivates) use. Feels like an incorrect use of plugin definitions to me, but I don't have any great ideas on how to change that, certainly not in the scope of this issue. So +1 I guess :)

Think it’s worth it to explore alternatives in a follow up?

So looking at contrib we need to think about this some more... for example we have https://git.drupalcode.org/project/media_entity_podbean/-/blob/1.0.x/src...
... sorry should have caught this earlier.

I think we need to create an new OEmbedMediaSource attribute that extends our new attribute. I think this will work just fine because we do an instanceof check in \Drupal\Component\Plugin\Discovery\AttributeClassDiscovery::parseClass and an is_a in \Drupal\Component\Annotation\Doctrine\StaticReflectionParser::hasClassAttribute()

Appears feedback for a separate oemebd attribute has been added.

Committed 7201d4b and pushed to 11.x. Thanks!
Committed 7f69b30 and pushed to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.