Fix "Not passing an instance of "TwigFunction" when creating a function of type "FunctionExpression" is deprecated."

Awesome! So exited you are fixing these so fast <3

1. Checked if we managed to get all the new FunctionExpression calls, even if a different function was used. None were left.
2. Tests are green.
3. Functionally this is precisely the same.

All good! RTBC from me.

Should we use the ::class constant instead of string class names?

Ow, yeah think you're right. If it doesn't mind we should indeed.

Not sure. Probably some real PHP developer required here,

    /**
     * @template TExtension of ExtensionInterface
     *
     * @param class-string<TExtension> $class
     *
     * @return TExtension
     */
    public function getExtension(string $class): ExtensionInterface
    {
        return $this->extensionSet->getExtension($class);
    }

requires string as param.

It shouldn't mind. I've seen problems with having a backslash or not. But that was while doing rector stuff. Rector is weird.

So make it a class string, that should be fine.

I'll push the small chnage. I made them but didn't push.

I applied your changes again and did a quick rebase because of external changes. If all is green i'll RTBC since my additions are really small :)

As mentioned in #12, going to RTBC since I did some quite small changes.

Committed and pushed 4b7624537e to 11.x and 4a20137738 to 11.0.x and 7a6c0a55aa to 10.4.x and f38c94f9b6 to 10.3.x. Thanks!

longwave → closed merge request !9666

Automatically closed - issue fixed for 2 weeks with no activity.

Hm this breaks decorating the ComponentsTwigExtension service since another namespaced object gets registered as extension to twig. Any idea on how to get around this?

This issue is pretty closed. Could you an new issue about this so we can investigate?