Convert ViewsFilter plugin discovery to attributes

Open on Drupal.org →

Created on 11 March 2024, about 1 year ago

Updated 30 April 2024, about 1 year ago

Problem/Motivation

In 📌 Use PHP attributes instead of doctrine annotations Fixed we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\views\Annotation\ViewsFilterplugins to use Attributes.

Proposed resolution

Add a class to represent the new Attribute - Example
Update the plugin manager constructor to include both the attribute and annotation class names - example
Convert all plugins that use the annotation to use the new attribute - example

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task

Status

Fixed

Version

10.3 ✨

Component

Last updated about 6 hours ago

Maintained by
🇩🇪Germany @dawehner
🇺🇸United States @tim.plunkett
🇬🇧United Kingdom @damiankloip
🇺🇸United States @xjm
🇳🇱Netherlands @Lendude

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Sign in to follow issues

Merge Requests

!7036Convert ViewsFilter plugin discovery to attributes
Closed
🇦🇺Australia mstrelan
updated about 1 year ago

Comments & Activities

Issue created by @mstrelan
Merge request !7036Issue #3426957: Convert ViewsFilter plugin discovery to attributes → (Closed) created by mstrelan
Status changed to Postponed about 1 year ago6:04am 14 March 2024
Comment about 1 year ago →
🇦🇺Australia mstrelan
Postponed on 📌 Convert ViewsField plugin discovery to attributes Needs review which has the required changes to ViewsHandlerManager.
Pipeline finished with Failed
about 1 year ago
Total: 528s
#118823
First commit to issue fork.
Pipeline finished with Failed
about 1 year ago
Total: 491s
#119841
Pipeline finished with Failed
about 1 year ago
Total: 496s
#119857
Status changed to Needs review about 1 year ago10:00am 15 March 2024
Comment about 1 year ago →
🇷🇺Russia sorlov
First commit to issue fork.
Pipeline finished with Success
about 1 year ago
Total: 482s
#120182
Status changed to Postponed about 1 year ago2:52pm 15 March 2024
Comment about 1 year ago →
🇺🇸United States smustgrave
📌 Convert ViewsField plugin discovery to attributes Needs review isn't in yet.
Status changed to RTBC about 1 year ago2:54pm 15 March 2024
Comment about 1 year ago →
🇺🇸United States smustgrave
Had some bandwidth and rebased which resolved the test failure and MR wasn't
in draft so went ahead and reviewed.

Searching core all 41 instances of @ViewsFilter have been replaced
Status changed to Fixed about 1 year ago5:21pm 16 March 2024
Comment about 1 year ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 8aa3632c61 to 11.x and 2ed3680d12 to 10.3.x. Thanks!
Comment about 1 year ago →
System Message

alexpott → committed 2ed3680d on 10.3.x
Issue #3426957 by sorlov, smustgrave, mstrelan: Convert ViewsFilter...
Comment about 1 year ago →
System Message

alexpott → committed 8aa3632c on 11.x
Issue #3426957 by sorlov, smustgrave, mstrelan: Convert ViewsFilter...
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Comment about 1 year ago →
System Message
mstrelan → closed merge request !7036

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024