Convert ViewsField plugin discovery to attributes

This adds ViewsHandlerAttributeBase which will be required for all related views handler plugin types. Not sure if ViewsHandlerManager will complain about other plugin attribute classes not existing yet, but we'll see what the tests say.

Changes look good, 0 results on search for @ViewsField, and tests are passing. This looks good, but I suggest adding one more change to update comments in \Drupal\views\Plugin\views\field\FieldPluginBase to reference attribute instead of annotation.

RTBC as per #4

Why are we adding ViewsHandlerAttributeBase - I can't see how it is used here?

We haven't added an equivalent to ViewsPluginAnnotationBase for views plugins so I don't think we should add one for views handlers.

Thanks @alexpott I wondered about that and have removed it now.

Searched for @ViewsField and all 59 instanes have been replaced

Seems the feedback to remove ViewsHandlerAttributeBase has been addressed also.

One comment and there's also a test failure.

I don't mind dropping named parameters, although it was advised again in another issue. I don't understand why you'd also swap back to double quotes when we general favour single quotes? Regardless, there seems to be a mix of both styles so no point changed back again now.

@mstrelan where do we have a mix of both double and single quotes?

Have not reviewed

But appears to have unit test failures

Had some bandwidth and rebased which resolved the test failure and MR wasn't in draft so went ahead and reviewed.

Searching core all 59 instances of @ViewsField have been replaced

Attribute plugin looks fine (super simple).

Committed and pushed e0f270ff66 to 11.x and 9d21eb5344 to 10.3.x. Thanks!

Did the 11.x/10.3.x commits get pushed? Getting 404 on both.

Also getting 404s on those

Automatically closed - issue fixed for 2 weeks with no activity.

mstrelan → closed merge request !6988