Config schema errors for entity types not listed in entity_clone.settings.schema.yml

Created on 7 May 2019, over 6 years ago
Updated 24 April 2023, over 2 years ago

Problem/Motivation

entity_clone.settings.schema.yml contains a list of known entity types. However, this schema does not cover any additional entity types that are installed through contrib modules.

Proposed resolution

Update entity_clone.settings.schema.yml to cover all entity types.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

🇳🇱Netherlands idebr

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update over 2 years ago
    Patch Failed to Apply
  • 🇷🇺Russia sorlov

    Rerolled patch for 2.x

  • Status changed to RTBC over 2 years ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update over 2 years ago
    28 pass, 3 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update over 2 years ago
    Patch Failed to Apply
  • Status changed to Needs work over 2 years ago
  • heddn Nicaragua
    +++ b/tests/src/Kernel/EntityCloneEntityTypeSettingsTest.php
    @@ -0,0 +1,36 @@
    +    $entity_clone_settings->set('form_settings', $form_settings)->save();
    

    The test should add an assert. Something like the following would probably be enough:

        try {
          $result = $this->configImporter()->validate();
          $this->assertInstanceOf(ConfigImporter::class, $result);
        }
        catch (ConfigImporterException $e) {
          $this->fail('A ConfigImporterException was thrown. This should not happen.');
        }
    
  • First commit to issue fork.
  • heddn Nicaragua

    The MR is simply a rehash of the latest patch. Can we add the requested test coverage too?

  • Pipeline finished with Failed
    about 1 year ago
    Total: 173s
    #258103
  • Pipeline finished with Failed
    about 1 year ago
    Total: 303s
    #258118
  • 🇷🇺Russia sorlov

    Added assertion to EntityCloneEntityTypeSettingsTest but now got it failed

  • Pipeline finished with Failed
    about 1 year ago
    Total: 1160s
    #258133
  • Pipeline finished with Failed
    about 1 year ago
    Total: 171s
    #258184
  • First commit to issue fork.
  • Pipeline finished with Canceled
    7 days ago
    Total: 82s
    #588786
  • Pipeline finished with Success
    7 days ago
    #588789
  • Pipeline finished with Success
    7 days ago
    Total: 205s
    #588798
  • Pipeline finished with Success
    7 days ago
    Total: 465s
    #588803
  • 🇸🇮Slovenia deaom

    Updated the test and re-based the branch. Tests are passing, setting status to needs review.

Production build 0.71.5 2024