- Issue created by @Grimreaper
- Issue was unassigned.
- π«π·France Grimreaper France π«π·
Let's do that in the 2.x version.
- First commit to issue fork.
- Assigned to elber
- π§π·Brazil elber Brazil
Hello @Grimreaper I think we can also implement a settings form to changes de settings defined in the schema file.
Another thing we should add a menu link to get access to this form.
What do you think?
- last update
almost 2 years ago 70 pass - π§π·Brazil elber Brazil
Hi I just added a basic schema but we have a lof of work to do, please answer my previously comment and the we can move to next steps
- Issue was unassigned.
- Status changed to Needs work
almost 2 years ago 4:25pm 27 June 2023 - π§πͺBelgium tim-diels Belgium π§πͺ
The basic schema added is incorrect. So this needs a new start.
- Assigned to Grimreaper
- π«π·France Grimreaper France π«π·
Grimreaper β changed the visibility of the branch 3336970-fix-config-schema to hidden.
- π«π·France Grimreaper France π«π·
I wonder if empty prop should be saved.
- Merge request !91Issue #3336970 by Grimreaper, pdureau: [2.0.0-alpha3] WIP: Fix config schema β (Merged) created by Grimreaper
- Issue was unassigned.
- π©πͺGermany Christian.wiedemann
christian.wiedemann β made their first commit to this issueβs fork.
- π©πͺGermany Christian.wiedemann
All tests are green now with strict schema validation. I also added schema validation to kernel tests so every source plugin is tested now. Happy about review.
- π©πͺGermany Christian.wiedemann
All tests are green now with strict schema validation. I also added schema validation to kernel tests so every source plugin is tested now. Happy about review.
- π«π·France Grimreaper France π«π·
Pipeline is red.
I made some review comments. In some comments, I said I need to check, so they are on my side.
I have tested with β¨ [10.1.x] Upgrade to UIP2 Active . Almost there! Thanks!
2 remaining points that I got multiple times:
This one is due to my custom field formatter in Sobki, on my side then:
This one is due to my source plugin in ui_styles_ui_patterns, on my side then:
- π«π·France Grimreaper France π«π·
Ok you fixed variant ID by the time I made my tests. :)
- π©πͺGermany Christian.wiedemann
I add nullable to component_id. This is needed for layouts
We have problems with 2 source plugins. ui_patterns_source.block and ui_patterns_source.entity_field
The problem is that one dynamic configuration key.source: block_id: 'block_name' block_name:
I can't use block_name in my mapping because it is dynamic . Better would be a configuration like:
source: block_id: 'block_name' configuration: block_name: ......
Here I can configure configuration as a sequence.
- π«π·France pdureau Paris
The most important is to not introduce breaking changes now. Shipping with a loosely defined schema is better than a breaking change in RC.
-
pdureau β
committed 15353e18 on 2.0.x authored by
grimreaper β
Issue #3336970 by christian.wiedemann, grimreaper, pdureau: Fix config...
-
pdureau β
committed 15353e18 on 2.0.x authored by
grimreaper β
Automatically closed - issue fixed for 2 weeks with no activity.