🇩🇪Germany @Christian.wiedemann

christian.wiedemann → created an issue.

christian.wiedemann → created an issue.

I updated the check for multi value slots.

christian.wiedemann → made their first commit to this issue’s fork.

christian.wiedemann → made their first commit to this issue’s fork.

Thanks!

Hi, not 100% sure what you try to do. You created your own field group form element which needs form state manipulation to store right?

I finalized the library integration and fixed some implementation detaisl. Ready to merge from my side.

I also checked the negiation mechanisms for the component itself. It is quite straightforward. It is done in ComponentNegotiator with. First it is checked if the component is in your theme and than the module weight is used for filtering the right component id.

$matches = array_filter(
      $all_definitions,
      static fn(array $definition) => $component_id === ($definition['replaces'] ?? NULL),
    );
    $negotiated_plugin_id = $this->maybeNegotiateByTheme($matches);
    if ($negotiated_plugin_id) {
      return $negotiated_plugin_id;
    }
    return $this->maybeNegotiateByModule($matches);

So there is only one replacement which is taken. The patch uses also the ComponentNegotiator to return the right id for the definition itself.

Hi, I fixed the tests and refactor the method so it easier to understand and maintanace. I alos tested with your code localy and it works as expected. Ready to merge from my side.

christian.wiedemann → created an issue.

g4mbini → credited christian.wiedemann → .

For clearification:
A Card from a base theme (BaseCard) is overwriten with a SubCard inside a theme.
So right now I hide SubCard everywhere because this SubCard should not be used for mapping or something else. It should always used the BaseCard as mapping target but with props/slots and template from the SubCard. We must ensure that already existing configs are working so we can't hide the BaseCard. Inside the library I would also recommend to hide the SubCard and only render the BaseCard with new slots and props and twig template and only say with "Replaced By" that the subcard is used here.
Hope it is more clear now.

I store the original slot configuration and readd them add the end of prefilled slots. So for example a source fills one slot and the layout builder also adds content to the slot. Both should be rendered.

I implemented the "context" approach. I think it is a bit simpler and maybe more helpful in other cases.
Can you check than we decide.

christian.wiedemann → made their first commit to this issue’s fork.

I am not sure how you use this in ds. But general the method returns an informativ text what is shown with label etc. But you can merge

christian.wiedemann → created an issue.

So I hide the components with a "replaces" from component selector / Layout and UIP UI. Inside the library it is a bit more complicated. Right now both components are visible but htis does not make sense from my point of view.

We should also hide the "replaces" component and inside the single view of the component we should switch from "replaces" to "Replaced by". Good?

Yes you are right but I think we should also hide the component in the library.

Can you check this if the behavior is right now. Now the component with "replaces" inside is taken into account for building slots and props in layout builder and library. But still both component appears. Is this right?

christian.wiedemann → created an issue.

Thanks! It is merged now.

christian.wiedemann → created an issue.

Will mark this as fixed now. Let me know if you still have problems.

It is merged now. This will land in beta2 which comes soon. Need to do some more tests. Thanks!

christian.wiedemann → created an issue.

I am not sure if I understand the problem. The right edit sidebar overlap the content. This is actually the current behavior for very long time. We did that because resizing the content leads to jumps and the editor loses the scope. But I am open to add a configuration where we can configure this behavior.

Hi, I fixed the linting in this branch. The toolbar looks good now expect that the background is not "black". Not sure if I should remove the last background: none;

This is the last class applied to the toolbar:

gin--classic-toolbar.glb-body .toolbar .toolbar-bar {
    position: fixed;
    inset-inline-start: 0;
    width: 100%;
    background: none;
    -webkit-box-shadow: none;
    box-shadow: none;
}

When I remove background:none it works.

christian.wiedemann → created an issue.

ah sorry this is already fixed

christian.wiedemann → created an issue.

christian.wiedemann → created an issue.

christian.wiedemann → created an issue.

christian.wiedemann → created an issue.

christian.wiedemann → created an issue.

christian.wiedemann → created an issue.

christian.wiedemann → created an issue.

christian.wiedemann → created an issue.

We will support this only in the 2.x branch. So will close this for now.

Hi this should fixed in https://www.drupal.org/project/gin_lb/issues/3520001#comment-16073448 📌 [2.0.x] Make navigation module optional in gin_lb Active . Can you check? Thanks!

Hi I fixed issues with the new navigation module in https://www.drupal.org/project/gin_lb/issues/3520001#comment-16073448 📌 [2.0.x] Make navigation module optional in gin_lb Active . Can you recheck your changes and maybe rebase than I will merge this soon. Thanks!

Hi I fixed that in https://www.drupal.org/project/gin_lb/issues/3520001#comment-16073448 📌 [2.0.x] Make navigation module optional in gin_lb Active . It should worrks now with and without the new navigation module. Can you check if it works for you?
Thanks!

This is already fixed.

christian.wiedemann → created an issue.

I added the prose component. Prose configuration should be done via ui styles from point of view. It is not possible to integrate typography with js only. We would need to add a custom js to handle this. Maybe we replace the js logic through prebuild css.

Heyho, I have added support for inline forms with floating labels or fieldset forms. You can adjust it inside the form settings. I also added basic phpstan and phpcs support.

I readded 10.3. @gareth.poole would be great if you can test things in 10.3. And if someone want to help as a co maintainer let me know.

Hi I readd 10.3. Sorry for the silent commit. I will add a first alpha after

https://www.drupal.org/project/gin_lb/issues/3516322 🐛 Classic toolbar style broken in LB v2.0.x Active

Will readd it now.

christian.wiedemann → made their first commit to this issue’s fork.

I added basic form templates to have a working boilerplate. I also removed the preprocess functions subthemes can easily overwrite that.

yes I decided to support drupal 11 mostly for testing purpose. I want to concentrate on drupal cms. I can readd drupal 10.3 but without active testing if that helps

We should add a option to handle this. Often it is better to overlap but of course there are cases which resize is better.

Hi, it should support both. I will check this soons before I relase the first alpha

christian.wiedemann → created an issue.

Is already added.

christian.wiedemann → created an issue.

Thanks!