In the 3.x branch is a option if the content is resized or not. Can you check if the problem still exists?
christian.wiedemann → made their first commit to this issue’s fork.
I think it is duplicate of https://www.drupal.org/project/gin_lb/issues/3530489 ✨ Add alter hooks to allow external modules and themes to extend ContextValidator form ID logic Active . Will close it for now. Let me know if I am wrong
I merged it to 3.x branch. Thanks for contributing.
Hi, do you use the gin also for frontend theme? Maybe we switch the "if" to if gin is used as default theme?
The idea is that *.pcss are only files which are included by other files.
The decoration stuff was not straight forward as a thought. Drupal Core doesn't resolve references well for that reason loading our components fails because the validation is done before the reference loading is done. So we need to ensure that our service is the first one loads the components and cache them to the decorated service. This works well with Canvas because Canvas added it logic to setCachedDefinitions.
Only one nitpic which is already wrong in the current MR
If Attributes is filled with "something" which is not an array and not attributes a type check would be good. (But this is also the case for attributes itself)
So a type check would increase the security:
$prop = $element['#props']['attributes'];
$prop_attributes = $prop instanceof Attribute
? $prop
: (is_array($prop) ? new Attribute($prop) : new Attribute());
$element['#props']['attributes'] = $element_attributes->merge($prop_attributes);
Not sure why the MR not appears. Here the link to the https://git.drupalcode.org/project/kern_ux/-/merge_requests/1/diffs#ccc2...
Hi @gcalex5 can you check. @just_like_good_vibes can you have a short look.
I removed the keys from corresponding configuration
christian.wiedemann → made their first commit to this issue’s fork.
Should we move this feature to the current 3.0.x branch?
christian.wiedemann → created an issue. See original summary → .
christian.wiedemann → made their first commit to this issue’s fork.
heyho nice wishes from munich. I rebased and added the abstract to the class.
1. From my point of view the PropTypeConversionTrait should be a service (PropTypeConverter). And the base class should simple provide the service for easy access.
2. We should avoid renderInIsolation. What is the use case behind. Can we check for '#markup' or #plain_text'?
$renderer = \Drupal::service('renderer');
$value = (string) $renderer->renderInIsolation($array);
if ($strip_tags_from_render_arrays) {
$value = strip_tags($value);
}