The logic was not working from my point of view. I refactored it a bit and added tests. Now it should work
Happy about review. Works well now.
christian.wiedemann → made their first commit to this issue’s fork.
Thanks! We should realy take care about changes in UI Patterns.
Ah shit. I will fix it. Sorry missunderstood the issue.
christian.wiedemann → made their first commit to this issue’s fork.
Reuploaded the patch without binary changes. These leads to problem with my composer installation. Not sure why.
christian.wiedemann → created an issue.
christian.wiedemann → created an issue.
christian.wiedemann → created an issue.
In the 3.x branch is a option if the content is resized or not. Can you check if the problem still exists?
Hi, Is this still happening in the 3.x branch?
christian.wiedemann → made their first commit to this issue’s fork.
christian.wiedemann → created an issue.
I think it is duplicate of https://www.drupal.org/project/gin_lb/issues/3530489 ✨ Add alter hooks to allow external modules and themes to extend ContextValidator form ID logic Active . Will close it for now. Let me know if I am wrong
I merged it to 3.x branch. Thanks for contributing.
Hi, do you use the gin also for frontend theme? Maybe we switch the "if" to if gin is used as default theme?
The idea is that *.pcss are only files which are included by other files.
christian.wiedemann → created an issue.
The decoration stuff was not straight forward as a thought. Drupal Core doesn't resolve references well for that reason loading our components fails because the validation is done before the reference loading is done. So we need to ensure that our service is the first one loads the components and cache them to the decorated service. This works well with Canvas because Canvas added it logic to setCachedDefinitions.
Only one nitpic which is already wrong in the current MR
If Attributes is filled with "something" which is not an array and not attributes a type check would be good. (But this is also the case for attributes itself)
So a type check would increase the security:
$prop = $element['#props']['attributes'];
$prop_attributes = $prop instanceof Attribute
? $prop
: (is_array($prop) ? new Attribute($prop) : new Attribute());
$element['#props']['attributes'] = $element_attributes->merge($prop_attributes);
christian.wiedemann → created an issue.
Not sure why the MR not appears. Here the link to the https://git.drupalcode.org/project/kern_ux/-/merge_requests/1/diffs#ccc2...
christian.wiedemann → created an issue.
I checked that localy. Looks good from my side.
christian.wiedemann → created an issue.
christian.wiedemann → created an issue.
christian.wiedemann → created an issue.
christian.wiedemann → created an issue.
christian.wiedemann → created an issue.
Hi @gcalex5 can you check. @just_like_good_vibes can you have a short look.
I removed the keys from corresponding configuration
christian.wiedemann → created an issue.
christian.wiedemann → created an issue.