- Issue created by @pdureau
- π«π·France pdureau Paris
It would be better to start working on this after π [1.0.0-beta1] Remove Island's specific Form classes Active is merged
- π©πͺGermany Christian.wiedemann
christian.wiedemann β made their first commit to this issueβs fork.
- @christianwiedemann opened merge request.
- π©πͺGermany Christian.wiedemann
Hi all, I set this to review. It is not done but a short review would help me to know if I am on the right path. We can discuss that on wendsday
I did:
* Add PluginFormInterface, ConfigurableInterface to IslandInterface
* Implement a sample base form with a dummy label.
* Add forms.
* Pass configuration to island.Questions:
* Should we make PluginFormInterface optional and add a basic implementation as a trait?
* Are there some basic configurations for every island. - π«π·France pdureau Paris
Are there some basic configurations for every island.
it is debatable, but i don't see any configuration shared by all islands. I can picture islands with no configuration.
By the way, you didn't add those first configs:
- components providers in component library (by default, disable
display_builder
). Today, it is hardcoded in::getDefinitionsForProvider()
- block providers in block library (by default, disable
ui_patterns_layouts
) - display "Clear" button in history buttons (must be hidden by default)
- buttons with labels, icons, or both.
Do we focus this issue to the mechanism, and move the addition of the first configs to island plugins in a follow-up issue?
- components providers in component library (by default, disable
- π«π·France pdureau Paris
TODO in the scope of this issue:
- display "Clear" button in history buttons (must be hidden by default)
Pierre will move this to another issue:
- components providers in component library (by default, disable display_builder). Today, it is hardcoded in ::getDefinitionsForProvider()
- block providers in block library (by default,disable ui_patterns_layouts)
- π©πͺGermany Christian.wiedemann
I finalized the island configuration part. Happy about review.
- π«π·France pdureau Paris
The expected config was not to display all the buttons or not, but only the "Reset" button:
display "Clear" button in history buttons (must be hidden by default)
- π«π·France mogtofu33
For the the configuration form of History island raise an ajax error without message.
- Fresh install
- Go to Default islands configuration
- Click configure in front of History
- -> Ajax error
- π«π·France mogtofu33
I struggled on the rebase so canceled it, would be probable easier to squash the current mr to one commit.
- π«π·France mogtofu33
mogtofu33 β changed the visibility of the branch 3529067-make-island-plugins to hidden.
- @mogtofu33 opened merge request.
- π«π·France mogtofu33
I created a rebased version, bug is still there, and cannot add a new DB config as well.
- π«π·France mogtofu33
Fixed the configure click problem, the route
{display_builder}/{instance_id}
was conflicting with{display_builder}/delete
Still have a problem when creating a new config of DB islands, the route require an id which is not ready yet and will raise an error. - π«π·France mogtofu33
Fixed the new case, some style review and should be ok.
-
mogtofu33 β
committed a6891e6f on 1.0.x
Issue #3529067 by christian.wiedemann, mogtofu33, pdureau: Make Island...
-
mogtofu33 β
committed a6891e6f on 1.0.x