- Issue created by @just_like_good_vibes
- 🇫🇷France mogtofu33
Currently focus is on 11, no specific work or test is made for 10.3.
We will try to follow UI Patterns 2.x compatibility in a second time if I have bandwidth. - 🇫🇷France Grimreaper France 🇫🇷
Regarding 📌 [1.0.0-alpha2] Play nice with layout builder Active , Layout Builder is using features introduced in the conversion of hooks into OOP code like https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/layou...
#[Hook('entity_view_alter', order: Order::Last)]
So I am not sure it will be feasible with Core 10.x
- 🇫🇷France pdureau Paris
Let's do it:
- Remove all references to Drupal 10. for example, in all info.yml:
core_version_requirement: ^10.3.4 || ^11
- Convert hooks to PHP class. This script may be useful: https://www.drupal.org/files/issues/2024-10-24/convertoop1.1.txt →
- Remove all references to Drupal 10. for example, in all info.yml:
- 🇫🇷France Grimreaper France 🇫🇷
For hooks as PHP class.
Which approach do we take?
- One class file for all hooks per module
- One file per hook
- One file per related hooks/logic if possible
I am for the one file per hook.
- 🇫🇷France pdureau Paris
Vote:
- one file per hook >> Florent
- a single file by module >> Mikael, Jean
- one file per related hooks/logic if possible >> Christian
As far as we know, the same mechanisms are available in all strategies.
By the way, we can do dependency injection.
Let's do a single file by module by default. If we consider later than it will be better to split (one file per hook, one file per related hooks/logic) , let's do it.
Let's migrate only
display_builder_views_preprocess_views_view
(because others ones are temporary or impossible).Let's not forget to remove all references to Drupal 10. For example, in all info.yml:
core_version_requirement: ^10.3.4 || ^11
- 🇫🇷France Grimreaper France 🇫🇷
display_builder_entity_view_module_implements_alter preserved as it will be deleted in 📌 [1.0.0-alpha2] Play nice with layout builder Active
- @grimreaper opened merge request.
-
mogtofu33 →
committed 0b533bf2 on 1.0.x authored by
grimreaper →
#3529362 by grimreaper, pdureau: Convert hooks to PHP class and drop...
-
mogtofu33 →
committed 0b533bf2 on 1.0.x authored by
grimreaper →