- Issue created by @michaellander
- πΊπΈUnited States michaellander
Front end is not my expertise, but I felt like rather than completely overriding the gin template, just using the `form_actions` variable already defined intop-bar--gin.html.twig would make it easier to support. This branch fixes functionality issues but still needs styling fixes.
- πΊπΈUnited States michaellander
I pushed some styling fixes that seem to be working pretty well on desktop at least..
- Status changed to Needs review
11 months ago 2:31pm 16 July 2024 - Status changed to Needs work
11 months ago 3:43am 18 July 2024 - πΊπΈUnited States michaellander
Looking into it more, we'd probably want to remove the dependency for gin_toolbar and core's toolbar and instead would want to conditionally work based on what modules exist on the given site. Definitely needs more work and maybe some guidance from maintainers.
- π«π·France Grimreaper France π«π·
Hi,
Thanks for your work on this issue.
I would wait to see how Gin will handle the new Navigation module. If some cases are deprecated like, now every one has a vertical toolbar, etc.
But having optional stuff for people no more using admin_toolbar and gin_toolbar would be very nice.
- πΊπΈUnited States yonghua
I've added a patch file for the 2.0.x branch in case anyone wanted to get these changes while using the 2.x version
- π©πͺGermany Christian.wiedemann
christian.wiedemann β made their first commit to this issueβs fork.
- Merge request !104Resolve #3457055 "Add support for 2.0.x" β (Merged) created by Christian.wiedemann
-
christian.wiedemann β
committed 48c0c64b on 2.0.x
Issue #3457055 by michaellander: Add support for core Navigation Top Bar
-
christian.wiedemann β
committed 48c0c64b on 2.0.x
- π©πͺGermany Christian.wiedemann
We will support this only in the 2.x branch. So will close this for now.
Automatically closed - issue fixed for 2 weeks with no activity.