Add support for core Navigation Top Bar

Created on 25 June 2024, 7 months ago
Updated 30 July 2024, 6 months ago

Problem/Motivation

As of Drupal 10.3, there's a new Navigation bar which includes an experimental Top Bar module. In time this may become the standard for front end secondary toolbar display. Gin has already extended the top bar behavior so it would be nice to add support in this module as well.

Steps to reproduce

1. Start with Drupal 10.3 and latest gin
2. Turn on 'Navigation' and 'Navigation Top Bar'
3. Turn off Gin secondary toolbar display on front end.
4. Go to layout builder and see missing form actions.

Proposed resolution

Embed the layout form actions into the new Top Bar either through extending Gin's override or preprocessing and altering an existing variable.

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Needs work

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States michaellander

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @michaellander
  • πŸ‡ΊπŸ‡ΈUnited States michaellander

    Front end is not my expertise, but I felt like rather than completely overriding the gin template, just using the `form_actions` variable already defined intop-bar--gin.html.twig would make it easier to support. This branch fixes functionality issues but still needs styling fixes.

  • πŸ‡ΊπŸ‡ΈUnited States michaellander

    I pushed some styling fixes that seem to be working pretty well on desktop at least..

  • Status changed to Needs review 7 months ago
  • πŸ‡ΊπŸ‡ΈUnited States michaellander
  • Merge request !93Resolve #3457055 "Add support for" β†’ (Open) created by michaellander
  • Pipeline finished with Success
    7 months ago
    Total: 169s
    #227379
  • Status changed to Needs work 7 months ago
  • πŸ‡ΊπŸ‡ΈUnited States michaellander

    Looking into it more, we'd probably want to remove the dependency for gin_toolbar and core's toolbar and instead would want to conditionally work based on what modules exist on the given site. Definitely needs more work and maybe some guidance from maintainers.

  • πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·

    Hi,

    Thanks for your work on this issue.

    I would wait to see how Gin will handle the new Navigation module. If some cases are deprecated like, now every one has a vertical toolbar, etc.

    But having optional stuff for people no more using admin_toolbar and gin_toolbar would be very nice.

Production build 0.71.5 2024