- Issue created by @larowlan
- Status changed to Active
about 1 year ago 11:39am 13 March 2024 - First commit to issue fork.
- ๐ฎ๐ณIndia ruturaj chaubey Pune, India
Ruturaj Chaubey โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 1 year ago 6:43am 15 March 2024 - Status changed to Needs work
about 1 year ago 6:44am 15 March 2024 - Status changed to Needs review
about 1 year ago 8:14am 15 March 2024 - Status changed to Needs work
about 1 year ago 8:47am 15 March 2024 The Needs Review Queue Bot โ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to Needs review
about 1 year ago 10:41am 15 March 2024 - Status changed to Needs work
about 1 year ago 2:21pm 15 March 2024 - ๐บ๐ธUnited States smustgrave
Appears to have a test failure, may need a rebase
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 9:26am 26 March 2024 - ๐ณ๐ฟNew Zealand quietone
I've added
register_theme: FALSE,
to the Serializer plugin because it does not define a theme. - Status changed to RTBC
about 1 year ago 1:52pm 26 March 2024 - ๐บ๐ธUnited States smustgrave
As before great investigative work @quietone
Searched the repo and all 14 instances of @ViewsStyle have been replaced.
Rest of changes seem fine to me.
- ๐บ๐ธUnited States smustgrave
Added some changes based on feedback from @alexpott on https://git.drupalcode.org/project/drupal/-/merge_requests/7035#note_287513
- Status changed to Needs work
about 1 year ago 2:04pm 26 March 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Added some comments to the MR.
- Status changed to RTBC
about 1 year ago 2:38pm 26 March 2024 - ๐บ๐ธUnited States smustgrave
Okay I fixed this one since I broke it before.
Applied the changes. Since they were minor going to remark RTBC.
- Status changed to Needs work
about 1 year ago 3:02pm 26 March 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Added some comments to the MR.
- Status changed to Needs review
about 1 year ago 1:12am 27 March 2024 - ๐ณ๐ฟNew Zealand quietone
Applied the suggestions from @alexpott and rebased.
- Status changed to RTBC
about 1 year ago 1:55pm 27 March 2024 - ๐บ๐ธUnited States smustgrave
Feedback appears to be addressed.
Sorry for breaking it before glad to see it wasn't hard to fix :)
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Committed and pushed f944f4886c to 11.x and a28538b0ab to 10.3.x. Thanks!
-
alexpott โ
committed a28538b0 on 10.3.x
Issue #3421005 by Ruturaj Chaubey, sorlov, quietone, smustgrave,...
-
alexpott โ
committed a28538b0 on 10.3.x
- Status changed to Fixed
about 1 year ago 3:33pm 27 March 2024 -
alexpott โ
committed f944f488 on 11.x
Issue #3421005 by Ruturaj Chaubey, sorlov, quietone, smustgrave,...
-
alexpott โ
committed f944f488 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.