- Issue created by @manpreetsingh154
- First commit to issue fork.
- Merge request !13Issue #3460644: 'image_style_*' is not a supported key getting issue with ckeditor5 → (Merged) created by jannakha
- Status changed to Needs review
4 months ago 2:42pm 17 July 2024 - 🇦🇺Australia jannakha Brisbane!
fixed is not a supported key by adding schema.yml for the filters
configuration structure has been updated to conform 10.3 requirements, related issues:
https://www.drupal.org/project/drupal/issues/3364108 📌 Configuration schema & required keys Fixed
https://www.drupal.org/project/drupal/issues/3412361 ✨ [PP-1] Mark parts of CKEditor 5 and Editor config schema as fully validatable Postponed
https://www.drupal.org/project/drupal/issues/3416223 📌 Mark config schema for CKEditor 5 text editor settings + each configurable CKEditor 5 plugin as FullyValidatable ActiveApply patch and update text format - configuration has a new structure/values
- Status changed to Needs work
4 months ago 10:41am 18 July 2024 - 🇷🇺Russia sorlov
Apply patch and update text format - configuration has a new structure/values
Then maybe we should provide hook_post_update to update existing formats that use these filters with new structure?
- 🇦🇺Australia jannakha Brisbane!
@sorlov
Your contributions to this module are welcome! - 🇷🇺Russia sorlov
Refactored config schema for module. It makes no sense to have different schema files for each filter plugin.
- Status changed to Needs review
4 months ago 7:58am 22 July 2024 - 🇷🇺Russia sorlov
Added hook_post_update_NAME() to update structure of settings for related filters in existing configs, Plz, review
- 🇦🇺Australia jannakha Brisbane!
@Sorlov - thanks so much for your contribution!
I tested post_update:
it's not saving the new format correctly.
I have rectified it in the latest commit:
please review/test.
hopefully someone will RTBC soon!
- Status changed to RTBC
3 months ago 12:52am 7 August 2024 I confirm that the patch from MR #13 solves the issue although we are using an old one. We are running Drupal 10.3.x and PHP 8.2.
- 🇫🇷France selinav
Is it possible to release a stable version now with all patchs ?
- 🇦🇺Australia VladimirAus Brisbane, Australia
@selinav I requested the access to the module months ago to do the release. Must be summer holidays.
Please comment on #3462761: Offering to maintain Inline responsive images → so it might have some impact. - 🇫🇷France selinav
#16 Thank you for your investment.
Have you received the right to maintain the project? They say that after 14 days without comments, you will automatically be co-maintainer. The comment was written 14 days ago, normally today or tomorrow it should be good.
I'm really looking forward to the project being resumed, because it's blocking my daily life.
- 🇩🇪Germany spuky
+1 for RTBC since @vladimiraus is a mainer now I am looking forward to a release (patches work.. )
-
vladimiraus →
committed b2ea10f8 on 3.x authored by
jannakha →
Issue #3460644: 'image_style_*' is not a supported key getting issue...
-
vladimiraus →
committed b2ea10f8 on 3.x authored by
jannakha →
- 🇦🇺Australia VladimirAus Brisbane, Australia
Thanks, everyone! Great work! 💪
Committed! 🎂 Automatically closed - issue fixed for 2 weeks with no activity.