Convert ViewsJoin plugin discovery to attributes

Open on Drupal.org →

Created on 11 March 2024, about 1 year ago

Updated 3 April 2024, about 1 year ago

Problem/Motivation

In 📌 Use PHP attributes instead of doctrine annotations Fixed we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\views\Annotation\ViewsJoinplugins to use Attributes.

Proposed resolution

Add a class to represent the new Attribute - Example
Update the plugin manager constructor to include both the attribute and annotation class names - example
Convert all plugins that use the annotation to use the new attribute - example

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task

Status

Fixed

Version

10.3 ✨

Component

Last updated about 8 hours ago

Maintained by
🇩🇪Germany @dawehner
🇺🇸United States @tim.plunkett
🇬🇧United Kingdom @damiankloip
🇺🇸United States @xjm
🇳🇱Netherlands @Lendude

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Sign in to follow issues

Merge Requests

!7051Convert ViewsJoin plugin discovery to attributes
Open
🇷🇺Russia sorlov
updated about 1 year ago

Comments & Activities

Issue created by @mstrelan
First commit to issue fork.
First commit to issue fork.
Merge request !7051Resolve #3426958 "Convert viewsjoin plugin" → (Open) created by sorlov
Status changed to Needs work about 1 year ago8:51am 15 March 2024
Comment about 1 year ago →
🇷🇺Russia sorlov
Pipeline finished with Failed
about 1 year ago
Total: 505s
#119777
Status changed to Needs review about 1 year ago9:12am 15 March 2024
Comment about 1 year ago →
🇷🇺Russia sorlov
Status changed to Needs work about 1 year ago2:01pm 15 March 2024
Comment about 1 year ago →
🇺🇸United States smustgrave
MR appears to have a failure.
Pipeline finished with Success
about 1 year ago
Total: 690s
#121934
Status changed to Needs review about 1 year ago4:21am 18 March 2024
Comment about 1 year ago →
🇷🇺Russia sorlov
Status changed to Needs work about 1 year ago5:13am 18 March 2024
Comment about 1 year ago →
🇦🇺Australia mstrelan
Same suggestions as #3426961-10: Convert ViewsSort plugin discovery to attributes →
Status changed to Needs review about 1 year ago9:32am 18 March 2024
Comment about 1 year ago →
🇷🇺Russia sorlov
Pipeline finished with Success
about 1 year ago
Total: 577s
#122117
Status changed to RTBC about 1 year ago2:09pm 18 March 2024
Comment about 1 year ago →
🇺🇸United States smustgrave
Searched the repo for @ViewsJoin and all 5 instances have been replaced

Also, let's update the description in \Drupal\views\Plugin\views\sort\SortPluginBase to mention attributes instead of annotations.

But for this ticket version, seems to have been addressed
Comment about 1 year ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed ff659267d9 to 11.x and 68f39ef12c to 10.3.x. Thanks!
Comment about 1 year ago →
System Message

alexpott → committed 68f39ef1 on 10.3.x
Issue #3426958 by sorlov, godotislate, mstrelan, smustgrave: Convert...
Status changed to Fixed about 1 year ago8:04am 20 March 2024
Comment about 1 year ago →
System Message

alexpott → committed ff659267 on 11.x
Issue #3426958 by sorlov, godotislate, mstrelan, smustgrave: Convert...
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024