- Issue created by @larowlan
- Status changed to Active
7 months ago 12:04am 15 February 2024 - First commit to issue fork.
- Status changed to Needs review
6 months ago 12:03pm 5 March 2024 - Status changed to Needs work
6 months ago 2:21pm 5 March 2024 - Status changed to Needs review
6 months ago 9:11am 6 March 2024 - Status changed to Needs work
6 months ago 2:51pm 7 March 2024 - πΊπΈUnited States smustgrave
Changes look good to me, all instances replaced, deriver class there with correct documentation.
Were you looking for something additional? The MR is in draft so I didn't mark it RTBC.
- Status changed to Needs review
6 months ago 3:57am 8 March 2024 - Status changed to RTBC
6 months ago 4:10am 8 March 2024 - Status changed to Needs work
6 months ago 10:58am 8 March 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Added a comment on the MR - the base_table field is a bit complex but I think it should be moved up and marked optional for now... and a follow-up opened to make it and title required.
- First commit to issue fork.
- Status changed to Needs review
5 months ago 2:03am 27 March 2024 - π³πΏNew Zealand quietone New Zealand
Made the changes asked for by alexpott and tests are passing, so setting to needs review.
This still needs a followup as explained in https://git.drupalcode.org/project/drupal/-/merge_requests/6916#note_278660
- π³πΏNew Zealand quietone New Zealand
Created the followup, π Make base_table and title required in ViewsWizard Active
- Status changed to RTBC
5 months ago 4:49pm 31 March 2024 - πΊπΈUnited States smustgrave
Appears feedback/follow ups are all done.
Searched the repo and all 11 instances of @ViewsWizard have been replaced. Nothing sticks out to me.
- Status changed to Needs work
5 months ago 11:23am 1 April 2024 - π¬π§United Kingdom alexpott πͺπΊπ
I checked how the plugin info is used in \Drupal\views_ui\ViewAddForm::form() and short title is not supported and given the titles are already short I think we should drop this from the definition and change things about a bit.
- Status changed to Needs review
5 months ago 4:48am 2 April 2024 - π³πΏNew Zealand quietone New Zealand
The recommended changes have been made and tests are passing.
- Status changed to Needs work
5 months ago 2:14pm 2 April 2024 - πΊπΈUnited States smustgrave
Based on the feedback appears TranslatableMarkup isn't suppose to be null.
- Status changed to Needs review
5 months ago 4:45am 4 April 2024 - Status changed to RTBC
5 months ago 1:33pm 4 April 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed 181221a429 to 11.x and 5786e6e83b to 10.3.x. Thanks!
-
alexpott β
committed 5786e6e8 on 10.3.x
Issue #3421000 by sorlov, quietone, smustgrave, larowlan, alexpott:...
-
alexpott β
committed 5786e6e8 on 10.3.x
- Status changed to Fixed
5 months ago 9:50pm 4 April 2024 -
alexpott β
committed 181221a4 on 11.x
Issue #3421000 by sorlov, quietone, smustgrave, larowlan, alexpott:...
-
alexpott β
committed 181221a4 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.