- First commit to issue fork.
- @vacho opened merge request.
- π§π΄Bolivia vacho Cochabamba
I added to MR changes at composer.json and .info. please review.
- Status changed to Needs review
over 1 year ago 6:48am 5 April 2023 - π«π·France andypost
Somehow tests not started for MR, checking patch
- Status changed to Needs work
over 1 year ago 7:42am 5 April 2023 - last update
over 1 year ago 8 fail - Status changed to Needs review
over 1 year ago 7:51pm 17 April 2023 - last update
over 1 year ago 7 fail - last update
over 1 year ago 6 fail - π«π·France andypost
test failure are from ctools π Fix PHP 8.2 deprecation notices and D10.1 compatibility Fixed
But the failure caused by added
assert()
AssertionError: Route page_manager.page_view_some_page_id_some_variant_id has broken overridden_route_name in /var/www/html/modules/contrib/panels_everywhere/src/Routing/PanelsEverywhereRouteSubscriber.php:109
- last update
over 1 year ago Checkout Error - last update
over 1 year ago 8 pass, 6 fail - π«π·France andypost
Front page test has changed since #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta β
- last update
over 1 year ago 8 pass, 6 fail - last update
over 1 year ago 21 pass, 2 fail - π«π·France andypost
curly braces could be removed from last variable (phpstorm complains about it), added to MR and here's interdiff and patch to run tests
- last update
over 1 year ago 21 pass, 2 fail - last update
over 1 year ago 8 pass, 6 fail - last update
over 1 year ago 8 pass, 6 fail - π«π·France andypost
+++ b/tests/src/Functional/PanelsEverywhereTest.php @@ -53,7 +53,7 @@ class PanelsEverywhereTest extends PanelsEverywhereBrowserTestBase { - $pageText = 'No front page content has been created yet.'; + $pageText = "You havenβt created any frontpage content yet.";
This comes from Olivero (core 9.1)
- πΊπΈUnited States DamienMcKenna NH, USA
Trying to see if this will fix the following error: Creation of dynamic property Drupal\panels_everywhere\Plugin\DisplayVariant\PanelsEverywhereDisplayVariant::$conditionManager is deprecated
- last update
over 1 year ago 21 pass, 2 fail - π«π·France andypost
It should be inherited in
ctools/Plugin/DisplayVariant/BlockDisplayVariant.php
and fixed via π Fix PHP 8.2 deprecation notices and D10.1 compatibility Fixed - last update
over 1 year ago 21 pass, 2 fail - last update
over 1 year ago 29 pass - π«π·France andypost
Looking at implementation this fixes needed to unit test to pass, interdiff vs #17 as *.2 compatibility require to fix ctools
Drupal\Tests\panels_everywhere\Functional\PanelsEverywhereTest::testOtherPages Exception: Deprecated function: Creation of dynamic property Drupal\panels_everywhere\Plugin\DisplayVariant\PanelsEverywhereDisplayVariant::$conditionManager is deprecated Drupal\ctools\Plugin\DisplayVariant\BlockDisplayVariant->__construct()() (Line: 94)
- π«π·France andypost
+++ b/src/EventSubscriber/PanelsEverywherePageDisplayVariantSubscriber.php @@ -152,7 +152,7 @@ class PanelsEverywherePageDisplayVariantSubscriber implements EventSubscriberInt - static function getSubscribedEvents() { + static function getSubscribedEvents(): array {
needed for 10.1 - future proof compatibility from SF
- last update
over 1 year ago 16 pass, 4 fail - last update
over 1 year ago 16 pass, 4 fail - last update
over 1 year ago 15 pass, 4 fail - last update
over 1 year ago 29 pass - last update
over 1 year ago 29 pass - last update
over 1 year ago 8 pass, 3 fail - last update
over 1 year ago 8 pass, 3 fail - Status changed to RTBC
over 1 year ago 4:26am 6 May 2023 - last update
over 1 year ago 29 pass - last update
over 1 year ago 29 pass -
andypost β
committed ed111358 on 8.x-4.x authored by
vacho β
Issue #3297809 by andypost, Project Update Bot, vacho, DamienMcKenna:...
-
andypost β
committed ed111358 on 8.x-4.x authored by
vacho β
- Status changed to Fixed
over 1 year ago 4:43am 6 May 2023 - π«π·France andypost
Filed follow-up π Fix overridden_route_name should not be empty Needs work
Automatically closed - issue fixed for 2 weeks with no activity.