Remove the persist service tag

I just hit this in ✨ Make it easier for theme builders to enable Twig debugging and disable render cache Fixed . How Drupal\Core\KeyValueStore\KeyValueMemoryFactory is tried to be persisted causes tests to break because the service isn't persisted.

Debasing patch #56

Given #58 should we split this into two issues? Deprecate the persist service tag in 10.3, and then remove it in 11.0?

Rebased against 11.x in a new branch on MR!6658. Locally the functional version of TwigDebugMarkupTest passes, so I removed the conversion to a kernel test here.

Should restoreServiceState() be decoupled from the kernel? Each persistent service could be responsible for transferring its data from the old to the new one, via an intermediate service that collects persist services tags and calls each service to do the work?

Hiding patches for clarity

Added #68 to remaining tasks

Moving to NW for change record unless you are waiting for an answer to 68 first, if that's the case can put back in review. But I didn't get that vibe that was the case.

andypost → changed the visibility of the branch 2368263-remove-the-persist to hidden.

Polished a bit new code

Re#68

Looking at UpdateKernel and InstallerKernel I see both overriding initializeContainer but calling parent, so I think it's ok to keep it in DrupalKernel

reroll after 📌 Fix Container::reset() and provide DrupalKernel::resetContainer() Needs review