Fix Container::reset() and provide DrupalKernel::resetContainer()

Making this major as it is part of 📌 Add the ability to install multiple modules and only do a single container rebuild to ModuleInstaller Needs review

Literally zero remarks on the MR.

All this needs now is a change record (for the few souls that have a custom DrupalKernelInterface implementation).

I'd also like to see a test-only run, but I can't trigger that — could you please do that, @alexpott? 🙏

Tagging for blocking 📌 Add the ability to install multiple modules and only do a single container rebuild to ModuleInstaller Needs review .

Created a CR and triggered a test only run.

Test-only job reports:

There was 1 error:
1) Drupal\Tests\Component\DependencyInjection\ContainerTest::testReset
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "service_container".

👍 🚢

Agreed that this looks great. Almost nothing to complain about in the MR, title, summary, or the CR. Really excited about the issue this is blocking! 🎉

I opened a few MR threads for optional questions to address, but this is ready as-is. +1 RTBC.

Thanks!
-Derek

Could you trigger the test-only job again now, to ensure that also after addressing @dww's review the test coverage still does what we think it does? 🙏

@Wim Leers done.

Left a couple of questions

Addressed @larowlan's feedback - thanks for the review!

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Fixed MR. It'd be great to land this so I can back to the issue this blocks.

Tried to do a thorough review here, because would love to see the blocked issue unblocked, but … IDK enough about this part of core to RTBC this. Hopefully @larowlan does another review 🤞

Thanks for adding the new test @alexpott - I think this is good to go now.

Merged 11.x and resolved use statement conflict in core/lib/Drupal/Core/DrupalKernelInterface.php due to 📌 Remove ContainerAwareInterface from DrupalKernelInterface Fixed
Opened a 10.3.x MR so we can backport this there.

Also can't find anything to complain about and the other issue will prove this is doing what it's supposed to on top of the extra test coverage here.

Committed/pushed to 11.x and 10.3.x respectively, thanks!

Published the CR

Thanks! Saving credits to match commit.

Sorry, stale form values.

Automatically closed - issue fixed for 2 weeks with no activity.