- Issue created by @longwave
- Status changed to Needs review
about 1 year ago 8:55pm 27 February 2024 - π¬π§United Kingdom longwave UK
DrupalKernel::initializeContainer()
does this:// If we haven't booted yet but there is a container, then we're asked to // boot the container injected via setContainer(). // @see \Drupal\KernelTests\KernelTestBase::setUp() if (isset($this->container) && !$this->booted) { $container = $this->container; }
but
KernelTestBase::setUp()
hasn't calledsetContainer()
since 2017: #2880911: Remove unused KernelTestBase::getCompiledContainerBuilder() βMaybe this is just dead code?
- Status changed to Needs work
about 1 year ago 2:05pm 28 February 2024 - π«π·France andypost
I think it's good clean-up of deadcode but interface change needs CR
- Status changed to Needs review
about 1 year ago 2:17pm 28 February 2024 - π¬π§United Kingdom longwave UK
Added https://www.drupal.org/node/3424376 β though I think it is super unlikely anyone will be affected by this, it was only added for KernelTestBase and is unused now for over six years.
- Status changed to RTBC
about 1 year ago 2:57pm 28 February 2024 - Status changed to Fixed
about 1 year ago 6:23pm 28 February 2024 - Status changed to RTBC
about 1 year ago 7:14pm 28 February 2024 - π¬π§United Kingdom longwave UK
As dead code IMHO this can go back to 10.3.x.
- Status changed to Fixed
about 1 year ago 9:52pm 28 February 2024 - π¬π§United Kingdom catch
It could if it cherry-picked, but it doesn't - and didn't seem worth spending the effort to backport it.
- π³πΏNew Zealand quietone
This was only fixed in 11.x
And published the CR
Automatically closed - issue fixed for 2 weeks with no activity.