- Issue created by @vacho
- Merge request !4831Issue #3388358: setPrefix when the param isn't a string → (Open) created by vacho
- last update
over 1 year ago 29,482 pass - Status changed to Needs review
over 1 year ago 7:50pm 19 September 2023 - Status changed to Needs work
over 1 year ago 6:10pm 20 September 2023 - 🇳🇱Netherlands daffie
+1 for this minor improvement.
We should add a small test for the improved error message.
- Status changed to Needs review
11 months ago 12:17am 15 February 2024 - 🇮🇳India sijumpk
Attaching test case for the issue. Patch made from the branch
3388358-setprefix-when-the
. Tried committing to the branch, but was unsuccessful. So adding it as a patch - last update
11 months ago Custom Commands Failed - Status changed to Needs work
11 months ago 3:05pm 15 February 2024 - Status changed to Needs review
11 months ago 6:02am 16 February 2024 - 🇮🇳India sijumpk
Updated the MR to 11.x version. Now tests are working as expected.
- Status changed to RTBC
11 months ago 11:20pm 18 February 2024 - 🇺🇸United States smustgrave
Removing tests tag based on https://git.drupalcode.org/issue/drupal-3388358/-/jobs/830872
Issue summary appears to be clear and change seems minor so feel fine marking now.
- Status changed to Needs work
10 months ago 9:24am 4 March 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Very tempted to close this a won't fix. There are quite a few more to "fix" if we want to make this change. I would argue that this change is not that helpful and if we do want to make it then we should at least fix it in \Drupal\pgsql\Driver\Database\pgsql\Connection::setPrefix() too.
- Status changed to Closed: won't fix
10 months ago 5:15pm 4 March 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Discussed with @catch and we decided that this is a won't fix.