- πΊπΈUnited States SocialNicheGuru
Is there a screenshot of what this new change will look like for the content creator? Is there a change in UI?
- π·πΊRussia ilya.no
I've noticed, that when we see list of libraries inside iframe in field widget, there is no icon for each library, located in web/libraries folder, because module tries to load it from sites/default folder.
So, here is the patch with the fix for this and also I've included latest changes from MR. - π§π΄Bolivia vacho Cochabamba
This patch fixes some issues about js-libraries paths..
- πΊπΈUnited States jackfoust
Just an FYI this patch no longer works with commit https://git.drupalcode.org/project/h5p/-/commit/289f5587bbcd3b38a6322b0c...
- πΊπΈUnited States jackfoust
In looking at the latest commit, do we simply need to drop the following from the most recent patch here?
diff --git a/src/Plugin/Field/FieldFormatter/H5PDefaultFormatter.php b/src/Plugin/Field/FieldFormatter/H5PDefaultFormatter.php index e1d4bafc..becfb9d2 100644 --- a/src/Plugin/Field/FieldFormatter/H5PDefaultFormatter.php +++ b/src/Plugin/Field/FieldFormatter/H5PDefaultFormatter.php @@ -61,7 +61,7 @@ class H5PDefaultFormatter extends FormatterBase { $preloaded_dependencies = $core->loadContentDependencies($h5p_content->id(), 'preloaded'); // Load dependencies - $files = $core->getDependenciesFiles($preloaded_dependencies, H5PDrupal::getRelativeH5PPath()); + $files = $core->getDependenciesFiles($preloaded_dependencies, H5PDrupal::getH5PLibrariesPath()); $loadpackages = [ 'h5p/h5p.content',
- π¬π§United Kingdom catch
@jackfoust yes removing that hunk ought to be fine, the latest changes are trying to rely on the libraries system as much as possible.
It would be great if you could rebase https://git.drupalcode.org/project/h5p/-/merge_requests/8 with that change and any of the interim ones - hard to follow what people are doing with patches here.