- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 7:29am 23 February 2023 - 🇮🇳India Gauravvv Delhi, India
I have added before/after screenshots for reference. please review
Before patch
After patch
- Status changed to Needs work
over 1 year ago 8:33pm 27 February 2023 - 🇺🇸United States smustgrave
Think some more nesting could be done. Especially with the tree classes.
- Status changed to Needs review
over 1 year ago 4:56am 28 February 2023 - Status changed to RTBC
over 1 year ago 4:59pm 28 February 2023 - 🇺🇸United States smustgrave
Reran the tests and it seemed to be a random failure.
Nesting looks good
- Status changed to Needs work
about 1 year ago 12:57pm 7 April 2023 - First commit to issue fork.
- First commit to issue fork.
- 🇺🇸United States mherchel Gainesville, FL, US
I did some additional significant refactoring. This stylesheet is a pain because tabledrag is a pain.
When we test this, we need to be extremely thorough. When testing in Safari (16.1 but also verified in 16.4), I noticed a pre-existing issue where the table rows are overly large. This patch fixes this too.
In regards to the
@nest
comments above with @nod_, we're having a discussion at https://drupal.slack.com/archives/C1BMUQ9U6/p1681135929045969 on whether we should be using it.Still setting to NR since it definitely needs additional testing.
- Status changed to Needs review
about 1 year ago 11:23am 24 April 2023 - 🇮🇳India pradipmodh13 Ahmedabad
Applied Patch. It's working fine.
For ref attached screenshot. - last update
about 1 year ago Custom Commands Failed - Status changed to Needs work
about 1 year ago 9:01pm 6 May 2023 - last update
about 1 year ago Custom Commands Failed - Status changed to Needs review
about 1 year ago 2:15pm 15 May 2023 - 🇺🇸United States mherchel Gainesville, FL, US
Just merged 10.1.x into the branch, and didn't have any conflicts.
- last update
about 1 year ago 29,388 pass - Status changed to RTBC
about 1 year ago 4:31pm 17 May 2023 - last update
about 1 year ago 29,388 pass - last update
about 1 year ago 29,387 pass, 2 fail - last update
about 1 year ago 29,387 pass, 2 fail - last update
about 1 year ago 29,388 pass - last update
about 1 year ago 29,395 pass - last update
about 1 year ago 29,399 pass - last update
about 1 year ago 29,399 pass - last update
about 1 year ago 29,400 pass - last update
about 1 year ago 29,409 pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
about 1 year ago Waiting for branch to pass - last update
about 1 year ago 29,418 pass - last update
about 1 year ago 29,420 pass - last update
about 1 year ago 29,420 pass 43:51 40:38 Running- last update
about 1 year ago 29,428 pass, 1 fail - last update
about 1 year ago 29,430 pass - last update
12 months ago 29,430 pass - last update
12 months ago 29,436 pass - last update
12 months ago 29,436 pass - last update
12 months ago Build Successful - last update
12 months ago 29,441 pass - last update
12 months ago 29,444 pass - last update
12 months ago 29,443 pass - last update
12 months ago 29,443 pass - last update
12 months ago 29,439 pass - last update
12 months ago 29,439 pass - last update
11 months ago 29,439 pass - last update
11 months ago 29,444 pass - last update
11 months ago 29,444 pass 43:50 40:11 Running- last update
11 months ago 29,446 pass - last update
11 months ago 29,422 pass, 2 fail - last update
11 months ago 29,446 pass - last update
11 months ago 29,450 pass - last update
11 months ago 29,453 pass - last update
11 months ago 29,454 pass - last update
11 months ago 29,455 pass - First commit to issue fork.
- last update
11 months ago 29,455 pass - last update
11 months ago 29,455 pass - Status changed to Needs work
11 months ago 6:36pm 30 July 2023 - 🇫🇮Finland lauriii Finland
There's still a regression on Safari where the table rows have a lot of extra padding after row has been moved:
- 🇬🇧United Kingdom psebborn
Picking this up as part of the Claro Contribution day
- Assigned to psebborn
- Status changed to Active
6 months ago 9:32am 15 December 2023 - 🇬🇧United Kingdom psebborn
Pushed a fix up for this to the existing MR, ready for review now.
- Issue was unassigned.
- Status changed to Needs review
6 months ago 2:52pm 15 December 2023 - Status changed to Needs work
6 months ago 4:21pm 15 December 2023 - 🇺🇸United States smustgrave
Thanks
Seems to have an order issue
themes/claro/css/components/tabledrag.css
266:3 ✖ Expected "float" to come before "flex-direction" order/properties-order
themes/claro/css/components/tabledrag.pcss.css
244:5 ✖ Expected "float" to come before "flex-direction" order/properties-order
2 problems (2 errors, 0 warnings) - Status changed to Needs review
6 months ago 8:31pm 15 December 2023 - 🇬🇧United Kingdom psebborn
Ah, my mistake. For some reason those errors weren't showing when running `yarn lint:css`. Fixed now and passing checks.
- Status changed to RTBC
6 months ago 4:27pm 16 December 2023 - last update
6 months ago Custom Commands Failed - last update
6 months ago Custom Commands Failed - last update
6 months ago Custom Commands Failed - last update
6 months ago Custom Commands Failed - last update
6 months ago Custom Commands Failed - last update
6 months ago Custom Commands Failed - last update
6 months ago Custom Commands Failed - Status changed to Needs review
6 months ago 4:11am 30 December 2023 - 🇳🇿New Zealand quietone New Zealand
I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions or other work to do.
When we test this, we need to be extremely thorough.
That is from #12. I see some test results in #19 but no other indication that this change has been thoroughly tested. Therefore, I am tagging for manual testing. I had to restore the standard issue template so I could add testing as a remaining task. Setting to Needs review for testing.
There are two MRs here. Can someone add to the issue summary which one is to be reviewed and hopefully close the other one. Thanks.
Both the MR has same code the difference is one for against branch 10.1.x ( MR3517 ) and the other one for branch 11.x ( MR5829 )
- 🇺🇸United States smustgrave
smustgrave → changed the visibility of the branch 3332683-refactor-claros-tabledrag to hidden.
- Status changed to RTBC
4 months ago 11:05pm 23 February 2024 - 🇺🇸United States smustgrave
So I tested using the Table Drag test module in core.
Altered the route tabledrag_test.test_form to use the claro theme.Everything appears to be lined up correctly.
I'm able to drag rows around without issue.
Highlighting appears to be the same with/without the MR. - Status changed to Needs work
4 months ago 8:46pm 29 February 2024 - 🇫🇷France nod_ Lille
There is change in the th alignement with this patch see screenshot. There is a width:auto missing apparently that is causing it.
- Status changed to Needs review
4 months ago 4:15am 4 March 2024 - 🇮🇳India Gauravvv Delhi, India
Addressed #32, Padding-inline-start: 0; was missing on draggable td,th.
- Status changed to RTBC
4 months ago 6:05pm 4 March 2024 - 🇺🇸United States smustgrave
Believe I'm seeing the issue reported in #32 has been addressed.
- Status changed to Needs work
4 months ago 7:08am 5 March 2024 - Status changed to Needs review
3 months ago 3:53pm 7 March 2024 - 🇬🇧United Kingdom psebborn
Replicated this issue in Firefox.
Fixed this and pushed it to the MR branch.Tested in Firefox, Safari, Chrome (on Mac, don't have access to another machine right now)
- Status changed to Needs work
3 months ago 11:12am 21 March 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India Mithun S Bangalore
Mithun S → made their first commit to this issue’s fork.
- Status changed to Needs review
about 1 month ago 6:22am 17 May 2024 - 🇮🇳India Mithun S Bangalore
Added a rebase and resolved the merge conflicts. Please review.
- Status changed to Needs work
30 days ago 10:47pm 19 May 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
29 days ago 5:41am 20 May 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
- Switched to 11.0.x branch
- Fixed stylelint
- Status changed to Needs work
29 days ago 6:07am 20 May 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.