thejimbirch → credited Stockfoot → .
thejimbirch → credited Stockfoot → .
I have fixed the PHPstan errors
Moving to "Needs review" status and unassigning myself from the issue, thank you!
I have fixed the errors flagged by PHPCS
Moving to "Needs review" status and unassigning myself, thank you!
Looks great!
Moving to "Reviewed and test by the community" status, thank you!
cspell linting is now passing.
I fixed a few typos and added the appropriate words to the ignore list.
Moving to "Needs review" status and unassigning myself from the issue, thank you!
Just like in the 5.0.x branch...
If you look at the cspell error, it flags 'Grey' and 'grey' repeatedly.
If you look at the variables section of the gitliab-ci.yml you can see the list of words that should be ignored.
Both 'Grey' and 'grey' are on the list but the linting continues to flag it.
I am unsure of why this is happening or exactly how to fix it.
The only place eslint fails is the jQuery .ready function wrapping the JS code.
I have tried 2 different code recommendations that should clear that eslint flag but was not able to get eslint to pass successfully.
If you look at the cspell error, it flags 'Grey' and 'grey' repeatedly.
If you look at the variables section of the gitliab-ci.yml you can see the list of words that should be ignored.
Both 'Grey' and 'grey' are on the list but the linting continues to flag it.
I am unsure of why this is happening or exactly how to fix it
I am assigning this task to myself to begin working on the issue.
I am assigning this task to myself to begin working on the issue.
I am assigning this task to myself to begin working on the issue.
I am flagging this as a duplicate issue that has already been completed here - https://www.drupal.org/project/bootstrap_paragraphs/issues/3439732 📌 Fix Linting Issues - 5.0.x-dev Needs review
There is 1 type in the following paragraph...
"Some paragraphs have fields that allow nesting of other paragraphs (Columns, Carousel, Tabs, Accordion, Modal). If you would like to expand on the already allowed nested paragraph types, for example, allow contact forms do be added to columns, follow these steps:"
We need it updated to "allow contact form to be added to columns" vs "do be added"
Moving to "Needs work" status and unassigning myself from the task, thank you!
Assigning myself to begin reviewing the issue, thanks!
The patch applied correctly but attempting to put a "Tab" component leads to a WSOD when the page loads.
I think something is missing in the syntax. My code editor shows a comment code color change that there is probably a missing character somewhere.
See the following image for reference before and after the patch.
Before patch on left, after patch on right.
Moving to "Needs work" status
Assigning myself to begin review on this issue.
I have completed fixing all the linting issues that were discovered by adding the gitlab-ci.yml file to the module.
I have also updated the variables in the gitlab-ci.yml file.
Moving to "Needs review" status and unassigning myself from the issue, thanks!
I have completed fixing all the linting issues that were discovered by adding the gitlab-ci.yml file to the module.
I have also updated the variables in the gitlab-ci.yml file.
Moving to "Needs review" status and unassigning myself from the issue, thanks!
This has fixed the "Expand All" or "Collapse All" button text and functionality.
The only thing I wasn't sure about is the default on load as the first accordion item is always open.
It is currently set to say "Collapse All" on load because of that first item being open. This made sense if the use case was a single accordion item.
This is now ready for Review, thanks!
I am assigning myself the task to begin the work, thanks Elena!
I have tested this and can confirm the expand/collapse all functionality of the accordion works correctly now.
Moving to "Reviewed and test by community" status, thanks!
Assigning this to myself to begin work on the issue, thanks!
Assigning this to myself to begin work on the issue, thanks!
I realized I assigned this myself and did not push a merge request.
I am beginning work on this issue, thanks!
I have updated and completed the child issue about copy edits - https://www.drupal.org/project/launch_checklist/issues/3274136 📌 Misc copy edits Needs review
Unassigning myself from the issue and moving to "Needs review" status. Thank you!
I have rolled the patch into a merge request that fixes missing periods and syntax and also updates the language for the mobile device testing.
Moving to "Needs review" status and unassigning myself from the issue, thanks!
Assigning to myself to begin work on the issue, thanks!
I have updated and completed the child issue about the duplicate items - https://www.drupal.org/project/launch_checklist/issues/3273628 📌 Second checkbox items appear as duplicate in General section Needs review
The verbiage on the two items has been corrected and the link in the "Other" section has been updated accordingly.
Moving to "Needs review" status and unassigning myself, thanks!
Stockfoot → changed the visibility of the branch 3273628-second-checkbox-items to hidden.
I am assigning this task to myself to begin work on the issue.
It appears at first that the checkboxes in the "General" section and the "Other" section are duplicates of each other.
General - The From address in automated emails sent during registration and new password requests, and other notifications.
Other - Ensure that the Drupal site email address is the correct client or site manager email address.
On further inspection, it appears that we need to update the "General" section item to say "Ensure that the Drupal site email address is the correct client or site manager email address." The URL in the link already points to /admin/config/system/site-information where that information already resides.
We then change the item in the "Other" section to state "The From address in automated emails sent during registration and new password requests, and other notifications." and point the link currently at /admin/config/system/site-information to /admin/config/people/accounts instead. This is where the email address can be entered for automated emails.
I am assigning myself this task to begin completing the issue
The .gitlab-ci.yml template file has been created and added to the module.
Move to "Needs review" status and unassigning myself, thanks!
Stockfoot → created an issue.
The .gitlab-ci.yml template file has been created and added to the module.
Move to "Needs review" status and unassigning myself, thanks!
Stockfoot → created an issue.
The .gitlab-ci.yml template file has been created and added to the module.
Move to "Needs review" status and unassigning myself, thanks!
Stockfoot → created an issue.
The .gitlab-ci.yml template file has been created and added to the module.
Move to "Needs review" status and unassigning myself, thanks!
Stockfoot → created an issue.
The .gitlab-ci.yml template file has been created and added to the module.
Move to "Needs review" status and unassigning myself, thanks!
Stockfoot → created an issue.
The .gitlab-ci.yml template file has been created and added to the module.
Move to "Needs review" status and unassigning myself, thanks!
Stockfoot → created an issue.
The .gitlab-ci.yml template file has been created and added to the module.
Move to "Needs review" status and unassigning myself, thanks!
The .gitlab-ci.yml template file has been created and added to the module.
Move to "Needs review" status and unassigning myself, thanks!
Stockfoot → created an issue.
Stockfoot → created an issue.
I have removed the text check on the path.
We have the assertion for the 200 response code which verifies the page loads.
Checking for the text 'Welcome to Drupal' would only work for standard/plain Drupal installs and not any custom themes
All tests are now passing
I tested the various paragraph types and everything shows when data is present.
Moving this to "RTBC" status and unassigning myself from the issue, thanks!
I am assigning this to myself to begin the review
I have tested this locally and can confirm the boolean "Open link in new window" field exists on the Image paragraph and works properly on the site's front end.
The patch was applied correctly.
I just want to note that when I did a 'drush updb' command there were "No pending updates" after the patch was applied.
Moving to the "Reviewed and tested by the community" status. Thanks all!
Assigning this task to myself to begin review
Please disregard this issue.
I accidentally created a duplicate that has already been completed here -
https://www.drupal.org/project/a11yproject_checklist/issues/3365689
📌
Drupal 10 Compatibility
Fixed
Stockfoot → created an issue.
I have completed making the changes to make sure that the tests are now passing with no errors.
Merge request - https://git.drupalcode.org/project/a11yproject_checklist/-/merge_requests/6
Moving to "In Review" status, thanks!
When running the phpunit test for the module, I received the following error:
Exception: You must provide a SIMPLETEST_BASE_URL environment variable to run some PHPUnit based functional tests.
This is because the SIMPLETEST_BASE_URL environment variable in the /web/core/phpunit.xml file defaults to an empty string. Setting the base URL of the project on which I was testing the module fixed this issue and allowed the tests to run further. However, this is not a good approach as we don't want to edit files in the /core folder.
Allowing the unit tests to run I found a few issues that I will fix in the upcoming merge request...
- Instances of
admin/config/development/a11yproject-checklistneed to be updated with an extra dash toadmin/config/development/a11y-project-checklist - $this->submitForm(['edit-checklistapi-content-use-plain-language' => '1',], t('Save')); is throwing the error
TypeError: Behat\Mink\Element\TraversableElement::findButton(): Argument #1 ($locator) must be of type string, Drupal\Core\StringTranslation\TranslatableMarkup given, called in /var/www/web/core/tests/Drupal/Tests/WebAssert.php on line 143
This has been tested successfully. Moving to the "Reviewed & test by the community" status.
I am assigning this to myself to begin reviewing the issue.
This has been tested successfully. Moving to the "Reviewed & test by the community" status.
I am assigning this to myself to begin the review process.
This is now ready for review, thank you!
I am assigning this to myself to begin working on the issue, thanks!
kerrymick → credited Stockfoot → .
This is now ready for review
I have updated the version install number and also added a function header comment block
I am assigning this to myself to begin work on the issue, thanks!
I have created a merge request - https://git.drupalcode.org/project/bootstrap_paragraphs/-/merge_requests/17
This merge request updates all the templates, the width variable on all the templates, and rewrites the accordion javascript to use Vanilla JS instead of jQuery.
This JS file also now properly targets the new template elements and removes a lot of unused variables from the old jQuery version.
Moving to "Needs Review" and unassigning myself from the issue, thanks!
I am this to myself to begin work on the issue
thejimbirch → credited Stockfoot → .
A pull request with the feature has been added to the cheatsheet to the official github - https://github.com/kanopi/shrubs
Pull Request URL - https://github.com/kanopi/shrubs/pull/22
I am unassigning the issue from myself and placing it into "Needs Review" status.
A pull request with the feature has been added to the cheatsheet to the official github - https://github.com/kanopi/shrubs
Pull Request URL - https://github.com/kanopi/shrubs/pull/21
I am unassigning the issue from myself and placing it into "Needs Review" status.
I am assigning this task to myself to begin work on the issue.
I am assigning this task to myself to begin working on the issue.
A pull request with the feature has been added to the cheatsheet to the official github - https://github.com/kanopi/shrubs
Pull Request URL - https://github.com/kanopi/shrubs/pull/19
I am unassigning the issue from myself and placing it into "Needs Review" status.
Thank you Elena, I have removed the external link attribute from the "Site User Roles" link that exists on the Permission tab.
This is now ready for review again
I am assigning this task to myself to begin work on this issue.
A pull request with the feature has been added to the cheatsheet to the official github - https://github.com/kanopi/shrubs
Pull Request URL - https://github.com/kanopi/shrubs/pull/18
I am unassigning the issue from myself and placing it into "Needs Review" status.
I am assigning this task to myself to begin working on the issue.
A pull request with the feature has been added to the commands at the official github - https://github.com/kanopi/shrubs
Pull Request URL - https://github.com/kanopi/shrubs/pull/17
I am unassigning the issue from myself and placing it into "Needs Review" status.
I am assigning this task to myself to begin work on the issue.
I have updated the pull request with the requested changes.
Pull Request URL - https://github.com/kanopi/shrubs/pull/16
A pull request with the feature has been added to the cheatsheet to the official github - https://github.com/kanopi/shrubs
Pull Request URL - https://github.com/kanopi/shrubs/pull/16
I am unassigning the issue from myself and placing it into "Needs Review" status.
I am assigning this issue to myself to begin work on it.
A pull request with the feature has been added to the cheatsheet to the official github - https://github.com/kanopi/shrubs
Pull Request URL - https://github.com/kanopi/shrubs/pull/16
I am unassigning the issue from myself and placing it into "Needs Review" status.
I am assigning this issue to myself to begin work on it.
A pull request with the feature has been added to the cheatsheet to the official github - https://github.com/kanopi/shrubs
Pull Request URL - https://github.com/kanopi/shrubs/pull/15
Unassigning the issue from myself and placing into "Needs Review" status.
A pull request with the feature has been added to the cheatsheet to the official github - https://github.com/kanopi/shrubs
Pull Request URL - https://github.com/kanopi/shrubs/pull/15
Unassigning the issue from myself and placing into "Needs Review" status.
A pull request with the feature has been added to the cheatsheet to the official github - https://github.com/kanopi/shrubs
Pull Request URL - https://github.com/kanopi/shrubs/pull/15
Unassigning the issue from myself and placing into "Needs Review" status.
I am assigning this to myself to begin working on the issue.
I am assigning this to myself to begin working on the issue.
I am assigning this to myself to begin work on the issue
Stockfoot → created an issue.
Stockfoot → created an issue.
Stockfoot → created an issue.
Stockfoot → created an issue.
I have reviewed and tested the PR branch locally.
Everything works as expected, PR is approved and ready to merge.