Fix Linting Issues - 5.0.x-dev

Created on 9 April 2024, 9 months ago
Updated 16 September 2024, 3 months ago

Linting Issues

Gitlab was recently installed and there are multiple linting issues that need to be resolved.

Version 5.0 View Issues here β†’

πŸ“Œ Task
Status

Fixed

Version

5.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States kerrymick Chicago

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @kerrymick
  • Assigned to Stockfoot
  • πŸ‡ΊπŸ‡ΈUnited States Stockfoot

    Assigning this to myself to begin work on the issue, thanks!

  • Merge request !31Resolve #3439732 "Fix linting issues" β†’ (Merged) created by Stockfoot
  • Pipeline finished with Success
    9 months ago
    Total: 181s
    #143041
  • Pipeline finished with Success
    9 months ago
    Total: 182s
    #143085
  • Pipeline finished with Success
    9 months ago
    #143086
  • Pipeline finished with Success
    9 months ago
    Total: 149s
    #143124
  • Pipeline finished with Success
    9 months ago
    Total: 449s
    #143142
  • Pipeline finished with Success
    9 months ago
    Total: 220s
    #143149
  • Pipeline finished with Success
    9 months ago
    Total: 178s
    #143164
  • Pipeline finished with Failed
    9 months ago
    #143171
  • Pipeline finished with Failed
    9 months ago
    #143172
  • Pipeline finished with Failed
    9 months ago
    #143176
  • Pipeline finished with Failed
    9 months ago
    #143175
  • Pipeline finished with Failed
    9 months ago
    #143182
  • Pipeline finished with Failed
    9 months ago
    #143183
  • Pipeline finished with Failed
    9 months ago
    #143186
  • Pipeline finished with Failed
    9 months ago
    #143187
  • Pipeline finished with Success
    9 months ago
    Total: 181s
    #143188
  • Pipeline finished with Failed
    9 months ago
    #143309
  • Pipeline finished with Failed
    9 months ago
    #143310
  • Pipeline finished with Success
    9 months ago
    Total: 144s
    #143311
  • Pipeline finished with Success
    9 months ago
    Total: 148s
    #143316
  • Pipeline finished with Success
    9 months ago
    Total: 144s
    #143325
  • Pipeline finished with Success
    9 months ago
    Total: 150s
    #143334
  • Pipeline finished with Success
    9 months ago
    Total: 180s
    #143338
  • Issue was unassigned.
  • Status changed to Needs review 9 months ago
  • πŸ‡ΊπŸ‡ΈUnited States Stockfoot

    I have completed fixing all the linting issues that were discovered by adding the gitlab-ci.yml file to the module.
    I have also updated the variables in the gitlab-ci.yml file.

    Moving to "Needs review" status and unassigning myself from the issue, thanks!

  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts
  • Status changed to Needs work 9 months ago
  • πŸ‡¨πŸ‡¦Canada taylor_wills

    Lint issues seem to be resolved, but cspell is still throwing a warning.

  • πŸ‡ΊπŸ‡ΈUnited States Stockfoot

    If you look at the cspell error, it flags 'Grey' and 'grey' repeatedly.
    If you look at the variables section of the gitliab-ci.yml you can see the list of words that should be ignored.
    Both 'Grey' and 'grey' are on the list but the linting continues to flag it.
    I am unsure of why this is happening or exactly how to fix it

  • Assigned to thejimbirch
  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts

    Great deduction!

    Looks like someone in Drupal core is very opinionated that it should be gray not grey as it is added to the cspell flagWords

    https://git.drupalcode.org/project/drupal/-/blob/11.x/core/.cspell.json?...

    The cspell documentation for forbidden words states we can override that using

    {
      "ignoreWords": ["forbiddenWord"]
    }
    

    I will try to add that now.

  • Status changed to Fixed 3 months ago
  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts

    That worked. There are still some minor issue that have been introduced, but we can address in follow ups.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024