- Issue created by @kerrymick
- Assigned to Stockfoot
- πΊπΈUnited States Stockfoot
Assigning this to myself to begin work on the issue, thanks!
- Issue was unassigned.
- Status changed to Needs review
9 months ago 10:20pm 10 April 2024 - πΊπΈUnited States Stockfoot
I have completed fixing all the linting issues that were discovered by adding the gitlab-ci.yml file to the module.
I have also updated the variables in the gitlab-ci.yml file.Moving to "Needs review" status and unassigning myself from the issue, thanks!
- Status changed to Needs work
9 months ago 2:27pm 12 April 2024 - π¨π¦Canada taylor_wills
Lint issues seem to be resolved, but cspell is still throwing a warning.
- πΊπΈUnited States Stockfoot
If you look at the cspell error, it flags 'Grey' and 'grey' repeatedly.
If you look at the variables section of the gitliab-ci.yml you can see the list of words that should be ignored.
Both 'Grey' and 'grey' are on the list but the linting continues to flag it.
I am unsure of why this is happening or exactly how to fix it - Assigned to thejimbirch
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Great deduction!
Looks like someone in Drupal core is very opinionated that it should be gray not grey as it is added to the cspell
flagWords
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/.cspell.json?...
The cspell documentation for forbidden words states we can override that using
{ "ignoreWords": ["forbiddenWord"] }
I will try to add that now.
- Status changed to Fixed
3 months ago 1:06pm 16 September 2024 - πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
That worked. There are still some minor issue that have been introduced, but we can address in follow ups.
-
thejimbirch β
committed ca231da2 on 5.0.x authored by
Stockfoot β
Resolve #3439732 "Fix linting issues"
-
thejimbirch β
committed ca231da2 on 5.0.x authored by
Stockfoot β
Automatically closed - issue fixed for 2 weeks with no activity.