- 🇺🇸United States Stockfoot
The patch has been tested via GitPod and locally using Drupal 9.
I have confirmed that the patch meets the acceptance criteria, as well as meeting PHP coding standards. - Status changed to RTBC
about 1 year ago 3:41pm 7 June 2023 - Issue was unassigned.
- Merge request !3Issue #3292866: External URLs need to open in New tab → (Merged) created by Stockfoot
- 🇺🇸United States Stockfoot
We were unable to apply the patch successfully on 1.x-dev.
I have re-rolled the patch into a GitLab merge request that is ready to go.https://git.drupalcode.org/project/launch_checklist/-/merge_requests/3
- 🇺🇸United States Stockfoot
The issues have been corrected on the merge request.
This is now ready for review again - Status changed to Needs review
11 months ago 5:13pm 27 July 2023 - Status changed to Needs work
8 months ago 6:48pm 16 November 2023 - 🇨🇦Canada Elena Chechulina
I've tested your code locally, all links work well and open in a New Tab, except this one: Site User Roles. You can find it in the User Permissions tab.
- Status changed to Needs review
6 months ago 7:04pm 8 January 2024 - 🇺🇸United States Stockfoot
Thank you Elena, I have removed the external link attribute from the "Site User Roles" link that exists on the Permission tab.
This is now ready for review again
- Status changed to RTBC
6 months ago 8:17pm 8 January 2024 - Status changed to Fixed
3 months ago 11:26pm 12 April 2024 - 🇺🇸United States thejimbirch Cape Cod, Massachusetts
Merging, thank all!
-
thejimbirch →
committed 36995116 on 1.x authored by
Stockfoot →
Issue #3292866: External URLs need to open in New tab
-
thejimbirch →
committed 36995116 on 1.x authored by
Stockfoot →
Automatically closed - issue fixed for 2 weeks with no activity.