- Issue created by @kerrymick
- Assigned to Stockfoot
- πΊπΈUnited States Stockfoot
Assigning this to myself to begin work on the issue, thanks!
- Issue was unassigned.
- Status changed to Needs review
9 months ago 5:39pm 11 April 2024 - πΊπΈUnited States Stockfoot
I have completed fixing all the linting issues that were discovered by adding the gitlab-ci.yml file to the module.
I have also updated the variables in the gitlab-ci.yml file.Moving to "Needs review" status and unassigning myself from the issue, thanks!
- Status changed to Needs work
9 months ago 2:31pm 12 April 2024 - π¨π¦Canada taylor_wills
Moving back to needs work - eslint is failing on the MR. Cspell also failed
- πΊπΈUnited States Stockfoot
Just like in the 5.0.x branch...
If you look at the cspell error, it flags 'Grey' and 'grey' repeatedly.
If you look at the variables section of the gitliab-ci.yml you can see the list of words that should be ignored.
Both 'Grey' and 'grey' are on the list but the linting continues to flag it.
I am unsure of why this is happening or exactly how to fix it.The only place eslint fails is the jQuery .ready function wrapping the JS code.
I have tried 2 different code recommendations that should clear that eslint flag but was not able to get eslint to pass successfully.