Fix Linting Issues - 8.x-2.x-dev

Created on 9 April 2024, 9 months ago
Updated 12 April 2024, 9 months ago

Linting Issues

Gitlab was recently installed and there are multiple linting issues that need to be resolved.

Version 8.2 View Issues here

πŸ“Œ Task
Status

Needs work

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States kerrymick Chicago

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @kerrymick
  • Assigned to Stockfoot
  • πŸ‡ΊπŸ‡ΈUnited States Stockfoot

    Assigning this to myself to begin work on the issue, thanks!

  • Pipeline finished with Success
    9 months ago
    #143357
  • Pipeline finished with Success
    9 months ago
    Total: 178s
    #143365
  • Pipeline finished with Success
    9 months ago
    Total: 146s
    #143371
  • Pipeline finished with Success
    9 months ago
    Total: 146s
    #143373
  • Pipeline finished with Success
    9 months ago
    Total: 285s
    #143376
  • Pipeline finished with Success
    9 months ago
    Total: 149s
    #143382
  • Pipeline finished with Success
    9 months ago
    Total: 150s
    #143389
  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts
  • Pipeline finished with Success
    9 months ago
    Total: 150s
    #144127
  • Pipeline finished with Success
    9 months ago
    Total: 180s
    #144142
  • Pipeline finished with Success
    9 months ago
    Total: 168s
    #144157
  • Pipeline finished with Success
    9 months ago
    Total: 152s
    #144162
  • Pipeline finished with Success
    9 months ago
    Total: 150s
    #144169
  • Pipeline finished with Success
    9 months ago
    #144170
  • Pipeline finished with Success
    9 months ago
    Total: 149s
    #144171
  • Pipeline finished with Success
    9 months ago
    Total: 145s
    #144175
  • Pipeline finished with Success
    9 months ago
    Total: 150s
    #144177
  • Pipeline finished with Success
    9 months ago
    Total: 151s
    #144179
  • Issue was unassigned.
  • Status changed to Needs review 9 months ago
  • πŸ‡ΊπŸ‡ΈUnited States Stockfoot

    I have completed fixing all the linting issues that were discovered by adding the gitlab-ci.yml file to the module.
    I have also updated the variables in the gitlab-ci.yml file.

    Moving to "Needs review" status and unassigning myself from the issue, thanks!

  • Pipeline finished with Success
    9 months ago
    Total: 151s
    #144181
  • Status changed to Needs work 9 months ago
  • πŸ‡¨πŸ‡¦Canada taylor_wills

    Moving back to needs work - eslint is failing on the MR. Cspell also failed

  • πŸ‡ΊπŸ‡ΈUnited States Stockfoot

    Just like in the 5.0.x branch...

    If you look at the cspell error, it flags 'Grey' and 'grey' repeatedly.
    If you look at the variables section of the gitliab-ci.yml you can see the list of words that should be ignored.
    Both 'Grey' and 'grey' are on the list but the linting continues to flag it.
    I am unsure of why this is happening or exactly how to fix it.

    The only place eslint fails is the jQuery .ready function wrapping the JS code.
    I have tried 2 different code recommendations that should clear that eslint flag but was not able to get eslint to pass successfully.

Production build 0.71.5 2024