πŸ‡¬πŸ‡§United Kingdom @psebborn

Account created on 3 August 2012, over 12 years ago
  • Head of Frontend Dev at ZoochaΒ 
#

Merge Requests

Recent comments

πŸ‡¬πŸ‡§United Kingdom psebborn

Rerolled the so it applies on the newer version, for those that rely on patches..

πŸ‡¬πŸ‡§United Kingdom psebborn

On further investigation it looks like it'll be resolved when https://www.drupal.org/project/gin/issues/3279620 πŸ“Œ RTL (right-to-left): change to logical CSS Needs work gets released.
Apologies for the superfluous ticket!

πŸ‡¬πŸ‡§United Kingdom psebborn

I've actioned the above points (added back the comment) - see MR for an explanation of why I've placed it inside the selector.

πŸ‡¬πŸ‡§United Kingdom psebborn

Was unable to attend but watched the recording for this

πŸ‡¬πŸ‡§United Kingdom psebborn

Thanks all! Merged; will be added to the next release

πŸ‡¬πŸ‡§United Kingdom psebborn

psebborn β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom psebborn

MR update and a new patch uploaded - there was a typo!

πŸ‡¬πŸ‡§United Kingdom psebborn

Thanks for this.
Fixed on the 2.x branch

πŸ‡¬πŸ‡§United Kingdom psebborn

I've created a MR with the fix; also attached a patch file for use if required.

πŸ‡¬πŸ‡§United Kingdom psebborn

I've rebased from 11.x which seems to has resolved the pipeline. Ready for review

πŸ‡¬πŸ‡§United Kingdom psebborn

psebborn β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom psebborn

Thanks for this!

πŸ‡¬πŸ‡§United Kingdom psebborn

Replicated this issue in Firefox.
Fixed this and pushed it to the MR branch.

Tested in Firefox, Safari, Chrome (on Mac, don't have access to another machine right now)

πŸ‡¬πŸ‡§United Kingdom psebborn

Discussed this on Slack with @mgifford. Their suggestion was to update the wording, along the lines of
"Ask on the Accessibility Channel of the Drupal Slack if you would like to be added to the calendars"

πŸ‡¬πŸ‡§United Kingdom psebborn

Ah, my mistake. For some reason those errors weren't showing when running `yarn lint:css`. Fixed now and passing checks.

πŸ‡¬πŸ‡§United Kingdom psebborn

psebborn β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom psebborn

psebborn β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom psebborn

Pushed a fix up for this to the existing MR, ready for review now.

πŸ‡¬πŸ‡§United Kingdom psebborn

Picking this up as part of the Claro Contribution day

πŸ‡¬πŸ‡§United Kingdom psebborn

psebborn β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom psebborn

Duplicate of https://www.drupal.org/project/image_lazy_loader/issues/3297403 πŸ’¬ Automated Drupal 10 compatibility fixes RTBC , closing

πŸ‡¬πŸ‡§United Kingdom psebborn

Added an updated patch without IDE-specific cruft

πŸ‡¬πŸ‡§United Kingdom psebborn

I've created a patch and MR for this, following a similar line @vishnukumar's original suggestion.
It is a bit heavy-handed, and I'm not a fan of having gin-specific code in the multiselect module, but needs must and I have a pressing to have *some* fix, which I'll share with you all :)

πŸ‡¬πŸ‡§United Kingdom psebborn

psebborn β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom psebborn

Just applied this patch and it's working well for me!

It feels as though the UX could be improved as the quote / author fields aren't immediately obvious but it's working so marking at RTBC

πŸ‡¬πŸ‡§United Kingdom psebborn

Updated the Merge Request now, removing those unnecessary styles as discussed

πŸ‡¬πŸ‡§United Kingdom psebborn

I would probably agree with that; as Claro's now the default admin theme it displays fine if those styles are removed. I left them in so as to keep support for Seven but perhaps that's an issue for Seven rather than Features UI?
Happy to update the merge request and remove them if that is the most appropriate course?

πŸ‡¬πŸ‡§United Kingdom psebborn

Created a merge request to fix this issue: for all themes except Claro the styles will be applied but for Claro it's left with the theme defaults.

πŸ‡¬πŸ‡§United Kingdom psebborn

I've created a merge request, for 2.1.x. Also attached a patch for 2.0.x to fix the following:

  1. Labels are now correctly read in Voiceover too, for the buttons
  2. The 'include description' checkbox is no longer read multiple times
  3. Added an `aria-pressed` attribute to show which button / display is active
πŸ‡¬πŸ‡§United Kingdom psebborn

Yes, I removed the changes from this commit https://git.drupalcode.org/project/drupal/-/commit/0c57711#80205155285d2... and the problem goes away.

I've updated the description to include this information, too.

Production build 0.71.5 2024