Rerolled the so it applies on the newer version, for those that rely on patches..
On further investigation it looks like it'll be resolved when
https://www.drupal.org/project/gin/issues/3279620
π
RTL (right-to-left): change to logical CSS
Needs work
gets released.
Apologies for the superfluous ticket!
psebborn β created an issue.
breidert β credited psebborn β .
I've actioned the above points (added back the comment) - see MR for an explanation of why I've placed it inside the selector.
dan2k3k4 β credited psebborn β .
Was unable to attend but watched the recording for this
I was here for this!
Thanks all! Merged; will be added to the next release
psebborn β made their first commit to this issueβs fork.
MR update and a new patch uploaded - there was a typo!
Thanks for this.
Fixed on the 2.x branch
I've created a MR with the fix; also attached a patch file for use if required.
psebborn β created an issue.
I've rebased from 11.x which seems to has resolved the pipeline. Ready for review
Fixed the ESLint issues in the open MR now. https://git.drupalcode.org/project/cookie_consent_notice/-/merge_requests/2
Ready for review.
psebborn β made their first commit to this issueβs fork.
Thanks for this!
Replicated this issue in Firefox.
Fixed this and pushed it to the MR branch.
Tested in Firefox, Safari, Chrome (on Mac, don't have access to another machine right now)
Discussed this on Slack with @mgifford. Their suggestion was to update the wording, along the lines of
"Ask on the Accessibility Channel of the Drupal Slack if you would like to be added to the calendars"
psebborn β created an issue.
Ah, my mistake. For some reason those errors weren't showing when running `yarn lint:css`. Fixed now and passing checks.
psebborn β made their first commit to this issueβs fork.
psebborn β made their first commit to this issueβs fork.
Pushed a fix up for this to the existing MR, ready for review now.
Picking this up as part of the Claro Contribution day
psebborn β made their first commit to this issueβs fork.
Duplicate of https://www.drupal.org/project/image_lazy_loader/issues/3297403 π¬ Automated Drupal 10 compatibility fixes RTBC , closing
Added an updated patch without IDE-specific cruft
I've created a patch and MR for this, following a similar line @vishnukumar's original suggestion.
It is a bit heavy-handed, and I'm not a fan of having gin-specific code in the multiselect module, but needs must and I have a pressing to have *some* fix, which I'll share with you all :)
psebborn β made their first commit to this issueβs fork.
Just applied this patch and it's working well for me!
It feels as though the UX could be improved as the quote / author fields aren't immediately obvious but it's working so marking at RTBC
Updated the Merge Request now, removing those unnecessary styles as discussed
I would probably agree with that; as Claro's now the default admin theme it displays fine if those styles are removed. I left them in so as to keep support for Seven but perhaps that's an issue for Seven rather than Features UI?
Happy to update the merge request and remove them if that is the most appropriate course?
Created a merge request to fix this issue: for all themes except Claro the styles will be applied but for Claro it's left with the theme defaults.
psebborn β created an issue.
psebborn β created an issue.
I've created a merge request, for 2.1.x. Also attached a patch for 2.0.x to fix the following:
- Labels are now correctly read in Voiceover too, for the buttons
- The 'include description' checkbox is no longer read multiple times
- Added an `aria-pressed` attribute to show which button / display is active
psebborn β created an issue.
Yes, I removed the changes from this commit https://git.drupalcode.org/project/drupal/-/commit/0c57711#80205155285d2... and the problem goes away.
I've updated the description to include this information, too.
psebborn β created an issue.