- Issue created by @mandclu
- ๐จ๐ฆCanada mandclu
Worth noting that the fix was suggested by @vishnukumar in the original issue.
Personally, I'm a little skeptical about indiscriminately selecting all form actions, which might not even be related to the form where the widget exists.
- First commit to issue fork.
- Status changed to Needs review
9 months ago 10:15pm 12 October 2023 - ๐ฌ๐งUnited Kingdom psebborn
I've created a patch and MR for this, following a similar line @vishnukumar's original suggestion.
It is a bit heavy-handed, and I'm not a fan of having gin-specific code in the multiselect module, but needs must and I have a pressing to have *some* fix, which I'll share with you all :) - ๐ฌ๐งUnited Kingdom psebborn
Added an updated patch without IDE-specific cruft
- ๐ฌ๐งUnited Kingdom aaron.ferris
Had a look at this.
Setup
Drupal: 10.2.4
Gin: 8.x-3.0-rc10
Multiselect: 2.0.0-beta4 r
Admin theme: Gin1. Basic page content type
2. Add list type field
3. Have several options
4. Change the field widget to multiselect
5. Add a basic page
6. Interact with the multiselect, add some options
7. Save the nodeWith the patch applied, the multi select doesn't seem to save any value. With Olivero it does. Could be my local setup.
- ๐บ๐ธUnited States ljwilson
Looks like multiselect 2.0.0-beta4 r changed some var variables to constants. For the error above, try changing the const to let for the $submit in line 11 of multiselect.js (with the patch already applied, of course).
That worked for me.
I've attached a re-rolled version of #6 which includes this one-word change.
- ๐ฎ๐ณIndia Tirupati_Singh
Hi, I've applied the MR !4 provided by @psebborn. The patch has been applied with no errors but it has not fixed the issue for multiselect. After applying the patch I'm unable to select any option from the select list and getting some console errors for the changes made on the
/multiselect/js/multiselect.js
file. If the list field is required then after applying the MR!4 patch the node is not being saved.
I've attached the console errors screenshot for reference.I've also applied the patch provided by @ljwilson in comment #9 ๐ Doesn't work with Gin admin theme Needs review . This patch has also applied with no errors but it has also not resolved the issue. After applying this patch the multiselect is not working as expected. Multiple list values are being added on
Selected options
field but on saving the node getting warning for the required field value ifRequired field
option has been checked while creating field. After selecting multiple option from the select list, I have to click on any select list item to make the node save and the selected list item is only being saved for the field.Test on:
Drupal: 10.2.5
Gin: 8.x-3.0-rc11
Admin Theme: Gin - Assigned to Tirupati_Singh
- Status changed to Needs work
11 days ago 6:58am 20 June 2024 - Issue was unassigned.
- Status changed to Needs review
11 days ago 3:43pm 20 June 2024 - ๐ฎ๐ณIndia Tirupati_Singh
Hi, I've fixed the multiple-value selection in multiselect field widget for Gin theme. Please review the changes.