yujiman85 → created an issue.
I checked this out and all mentions of Drupal CI seem to be gone, I also reran the pipeline to get it to pass. I can't comment on the new wording of the comments since I don't know what it's supposed to become so I'll leave this as Needs Review for now.
Should this be closed?
I followed the step-by-step directions for this issue and the only time the header disappeared was when there were no results after using an exposed filter. I was able to get the header to stay by enabling "Display even if view has no result" and it was permanently visible. Basically I couldn't reproduce this consistently, just my observation.
Drupal 10.3.10
View block with Ajax enabled
Global text area using token [site:base-url]
Exposed filters for title and published state
I moved the change into the Olivero theme and targeted the ID for that div. Needs a review.
Branch is updated and just needs a review.
This looks like it needs a rebase so I can take care of that.
@smustgrave Alright, I believe I did this right. I rebased the branch and it is up to date now with the commits from this branch. Needs a review.
I wasn't sure if the .js files needed to be touched since those seemed compiled and minified. Please correct me if I'm wrong. This needs a review.
Taking this on to make the other changes.
Needs a review!
Going to work on this one and make the updates.
Needs a review.
Assigned to myself to take a look and make the required changes.
+1 for #11. I applied the MR as a patch and it fixed the issue saving multi-select values using the Gin admin theme.
Drupal: 10.3.0
Admin Theme: Gin 8.x-3.0-rc12
Multiselect: 2.0.0-beta4
Any update on this? I'm having a very similar issue.
Gave it some more thought and came up with another revision.
I agree with #6, that is a bit clearer so I updated the MR. Thank you. Is that clear enough without having to state that the libraries are registered by $extension? I guess "Can either be 'core' or the machine name of the extension that registered the libraries." kinda clears that up.
I added some examples of other data types, added a note about using "\" before classes. Just need confirmation that the examples used and the note about classes are okay.
Module prefixes removed
I tried to add some clarity as to how libraries are referenced in the code as well as provide an example.
Yujiman85 → made their first commit to this issue’s fork.
Since this technically works like it's supposed to after changing how the namespaces are structured, I'm going to move this over to "Closed (works as designed)". If that isn't right someone please move it back. The documentation for the API is there but it's two clicks deep from the module page, maybe there could be a more noticeable section highlighting how to structure the namespaces? Especially now since the old way doesn't seem to work after moving to v3.
I had the same issue with templates not being defined in Twigs using "extends" after the update to the latest version. It seems I was able to fix the situation by updating the namespaces in the info.yml file for my custom theme from the old API to the new one as per https://www.drupal.org/docs/contributed-modules/components/registering-twig-namespaces → . Not sure if this will work for anyone else but worth a shot if your situation is at all similar.
Old:
component-libraries:
[THEMENAME]:
paths:
- components
New:
components:
namespaces:
[THEMENAME]:
- components
So far I haven't run into any breaking issues but if I do I'll come back to update