- Issue created by @joachim
- First commit to issue fork.
- last update
over 1 year ago 30,148 pass - @yujiman85 opened merge request.
- Status changed to Needs review
over 1 year ago 6:03pm 12 September 2023 - 🇺🇸United States yujiman85
I tried to add some clarity as to how libraries are referenced in the code as well as provide an example.
- Status changed to RTBC
over 1 year ago 2:20pm 13 September 2023 - Status changed to Needs work
over 1 year ago 7:14pm 13 September 2023 - 🇺🇸United States xjm
Nice improvement!
It was still not immediately obvious to me how the library name was connected to the example when I first read the documentation out of context, so I suggested a slight improvement.
Thanks!
- last update
over 1 year ago Custom Commands Failed - Status changed to Needs review
over 1 year ago 8:10pm 13 September 2023 - 🇺🇸United States yujiman85
I agree with #6, that is a bit clearer so I updated the MR. Thank you. Is that clear enough without having to state that the libraries are registered by $extension? I guess "Can either be 'core' or the machine name of the extension that registered the libraries." kinda clears that up.
- Status changed to Needs work
over 1 year ago 8:36pm 13 September 2023 - 🇺🇸United States xjm
CS failure (wish it would mark the issue NW):
FILE: /var/www/html/core/lib/Drupal/Core/Render/theme.api.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 1016 | ERROR | [x] Whitespace found at end of line | | (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine) ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------
I also think we should keep the first sentence about it being an associative array. It's not a library; it's an array of libraries. Right?
- last update
over 1 year ago 30,154 pass - Status changed to Needs review
over 1 year ago 7:56pm 14 September 2023 - 🇺🇸United States yujiman85
Gave it some more thought and came up with another revision.
- Status changed to RTBC
over 1 year ago 9:24pm 19 September 2023 - last update
over 1 year ago 30,168 pass - last update
over 1 year ago 30,168 pass - last update
about 1 year ago 30,205 pass - last update
about 1 year ago 30,363 pass - Status changed to Fixed
about 1 year ago 4:24pm 27 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.