Spacing issue between Checkbox label and button

Spacing issue between Checkbox label and button has been fixed.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.

This looks like it needs a rebase so I can take care of that.

Branch is updated and just needs a review.

Reviewed Issue is fixed.

Steps to reproduce.
1 : Fresh install Drupal 11 and use default Olivero theme.

2 : Enable layout builder module

3 : Use Layout Builder from Administration > Structure > Content types > Basic page > Manage display > default > layout options

4 : Create Basic page from Content > Add content > Basic page and Save
Step5 : Click on Layout tab and you can find the spacing issue between Checkbox label and button.
5. Issue is fixed with give MR.

Completed the issue summary.

Can confirm the issue on 11.x and that the MR addresses the problem.

I moved the change into the Olivero theme and targeted the ID for that div. Needs a review.

As per previous comments changes are now moved to Olivero theme and targeted the ID for that div.
I can confirm on 11.x updated MR addresses the problem. https://www.drupal.org/project/drupal/issues/3463111#comment-15746322 🐛 Spacing issue between Checkbox label and button Needs review

Adding screenshot for reference.

Steps to reproduce.
1 : Fresh install Drupal 11 and use default Olivero theme.

2 : Enable layout builder module

3 : Use Layout Builder from Administration > Structure > Content types > Basic page > Manage display > default > layout options

4 : Create Basic page from Content > Add content > Basic page and Save
Step5 : Click on Layout tab and you can find the spacing issue between Checkbox label and button.
5. Issue is fixed with give MR.

Hello
I have reproduced the issue for Spacing issue between Checkbox label and button on Drupal 11.
The MR is applied successfully.

Steps to reproduce
Step1 : Fresh install Drupal 11 and use default Olivero theme.
Step2 : Enable layout builder module
Step3 : Use Layout Builder from Administration > Structure > Content types > Basic page > Manage display > default > layout options
Step4 : Create Basic page from Content > Add content > Basic page and Save
Step5 : Click on Layout tab and you can find the spacing issue between Checkbox label and button.

See attached screen shot for reference.

Test Result:
Spacing issue between Checkbox label and button has been fixed.
Check attachments.

RTBC+1

Restoring tags

MR appears to have an issue.

FYI when making a css change have to edit the pcss first and recompile.

sanket.tale → made their first commit to this issue’s fork.

I've moved to Needs Review but I'll be leading some new contributors tomorrow through things and this would be a great one for them to check. Can you leave any review until at least the weekend? Thanks!

Hi! We'll be reviewing this change today as a group; this is our first time contributing.

Hello, We're going to be testing this changes for our first contribution.

Thanks, better.
We try our best to not use IDs in CSS, so have a look at how umami solves this issue and apply the same to Olivero/Claro.
The problem happens also on Claro, so that needs fixing there as well.

Nice, Claro also need the fix

I have fixed Spacing issue between Checkbox label and button for Claro theme.

Adding screenshot for reference.

Steps to reproduce.
1 : Fresh install Drupal 11 and use default Claro theme.

2 : Enable layout builder module

3 : Use Layout Builder from Administration > Structure > Content types > Basic page > Manage display > default > layout options

4 : Create Basic page from Content > Add content > Basic page and Save
Step5 : Click on Layout tab and you can find the spacing issue between Checkbox label and button.

Restoring status.

I read the IS, comments, and the MR. There are no unanswered questions. I did not test this.

Leaving at RTBC.

question in MR

A quick update to the MR to resolve issues mentioned by Nod_ and keep the issue rolling forwards.

I’ve updated the test steps a little to say that the test needs to be performed both in Olivero and Claro.

Of course, this now needs the manual tests re-running to ensure that the change applies to BOTH Claro and Olivero. So, four screenshots. That is, once again, a perfect Novice task...

Hello
I have reproduced the issue for Spacing issue between Checkbox label and button on Drupal 11.
The MR is applied successfully.

Steps to reproduce
Step1 : Fresh install Drupal 11 and use default Olivero theme.
Step2 : Enable layout builder module
Step3 : Use Layout Builder from Administration > Structure > Content types > Basic page > Manage display > default > layout options
Step4 : Create Basic page from Content > Add content > Basic page and Save
Step5 : Click on Layout tab and you can find the spacing issue between Checkbox label and button.

See attached screen shot for reference.

Test Result:
Spacing issue between Checkbox label and button has been fixed.
Check attachments.

Awesome, thanks Sagar. Can you repeat the test looking at the page via the Claro theme? Then, if successful, set the status to Reviewed and Tested by the Community?

Hello rachel_norfolk,
I have reproduced the issue for Spacing issue between Checkbox label and button on Drupal 11 for Claro.
The MR is applied successfully.

Steps to reproduce
Step1 : Fresh install Drupal 11 and use default Claro theme.
Step2 : Enable layout builder module
Step3 : Use Layout Builder from Administration > Structure > Content types > Basic page > Manage display > default > layout options
Step4 : Create Basic page from Content > Add content > Basic page and Save
Step5 : Click on Layout tab and you can find the spacing issue between Checkbox label and button.

See attached screen shot for reference.

Test Result:
Spacing issue between Checkbox label and button has been fixed.
Check attachments.

nod_ → closed merge request !8879

Welcome to all the new folks!

Committed bec7d01 and pushed to 11.x. Thanks!
Committed c1401cc and pushed to 11.0.x. Thanks!
Committed 31afe9d and pushed to 10.4.x. Thanks!
Committed bb1fad9 and pushed to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.