Spacing issue between Checkbox label and button

Created on 22 July 2024, about 2 months ago
Updated 6 September 2024, 1 day ago

Problem/Motivation

Steps to reproduce

Step1 : Fresh install Drupal 11 and use default Olivero theme.
Step2 : Enable layout builder module
Step3 : Use Layout Builder from Administration > Structure > Content types > Basic page > Manage display > default > layout options
Step4 : Create Basic page from Content > Add content > Basic page and Save
Step5 : Click on Layout tab and you can find the spacing issue between Checkbox label and button.

See attached screen shot for reference.

Proposed resolution

Add some spacing on right side of "Show content preview" label.

Remaining tasks

Review

User interface changes

Before

After

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

๐Ÿ› Bug report
Status

Needs work

Version

11.0 ๐Ÿ”ฅ

Component
CSSย  โ†’

Last updated 1 day ago

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia jaydeep.jdb@gmail.com Ahmedabad

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @jaydeep.jdb@gmail.com
  • Issue was unassigned.
  • Status changed to Needs review about 2 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia jaydeep.jdb@gmail.com Ahmedabad

    Spacing issue between Checkbox label and button has been fixed.

  • Pipeline finished with Success
    about 2 months ago
    Total: 684s
    #231269
  • Status changed to Needs work about 2 months ago
  • The Needs Review Queue Bot โ†’ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

    This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

    Consult the Drupal Contributor Guide โ†’ to find step-by-step guides for working with issues.

  • ๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand quietone New Zealand

    Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.

  • Assigned to Yujiman85
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States Yujiman85

    This looks like it needs a rebase so I can take care of that.

  • Issue was unassigned.
  • Status changed to Needs review 13 days ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States Yujiman85

    Branch is updated and just needs a review.

  • Pipeline finished with Success
    13 days ago
    Total: 661s
    #265174
  • Reviewed Issue is fixed.

    Steps to reproduce.
    1 : Fresh install Drupal 11 and use default Olivero theme.โ€จ
    2 : Enable layout builder moduleโ€จ
    3 : Use Layout Builder from Administration > Structure > Content types > Basic page > Manage display > default > layout optionsโ€จ
    4 : Create Basic page from Content > Add content > Basic page and Saveโ€จStep5 : Click on Layout tab and you can find the spacing issue between Checkbox label and button.
    5. Issue is fixed with give MR.

  • Status changed to RTBC 12 days ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    Completed the issue summary.

    Can confirm the issue on 11.x and that the MR addresses the problem.

  • Status changed to Needs work 12 days ago
  • ๐Ÿ‡ซ๐Ÿ‡ทFrance nod_ Lille
  • Status changed to Needs review 11 days ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States Yujiman85

    I moved the change into the Olivero theme and targeted the ID for that div. Needs a review.

  • Pipeline finished with Failed
    11 days ago
    Total: 465s
    #266361
  • Pipeline finished with Failed
    11 days ago
    Total: 278s
    #266366
  • As per previous comments changes are now moved to Olivero theme and targeted the ID for that div.
    I can confirm on 11.x updated MR addresses the problem. https://www.drupal.org/project/drupal/issues/3463111#comment-15746322 ๐Ÿ› Spacing issue between Checkbox label and button Needs review

    Adding screenshot for reference.

    Steps to reproduce.
    1 : Fresh install Drupal 11 and use default Olivero theme.โ€จ
    2 : Enable layout builder moduleโ€จ
    3 : Use Layout Builder from Administration > Structure > Content types > Basic page > Manage display > default > layout optionsโ€จ
    4 : Create Basic page from Content > Add content > Basic page and Saveโ€จStep5 : Click on Layout tab and you can find the spacing issue between Checkbox label and button.
    5. Issue is fixed with give MR.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia sagarmohite0031

    Hello
    I have reproduced the issue for Spacing issue between Checkbox label and button on Drupal 11.
    The MR is applied successfully.

    Steps to reproduce
    Step1 : Fresh install Drupal 11 and use default Olivero theme.
    Step2 : Enable layout builder module
    Step3 : Use Layout Builder from Administration > Structure > Content types > Basic page > Manage display > default > layout options
    Step4 : Create Basic page from Content > Add content > Basic page and Save
    Step5 : Click on Layout tab and you can find the spacing issue between Checkbox label and button.

    See attached screen shot for reference.

    Test Result:
    Spacing issue between Checkbox label and button has been fixed.
    Check attachments.

    RTBC+1

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    Restoring tags

  • Status changed to Needs work 7 days ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    MR appears to have an issue.

    FYI when making a css change have to edit the pcss first and recompile.

  • sanket.tale โ†’ made their first commit to this issueโ€™s fork.

  • Status changed to Needs review 3 days ago
  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom rachel_norfolk UK

    I've moved to Needs Review but I'll be leading some new contributors tomorrow through things and this would be a great one for them to check. Can you leave any review until at least the weekend? Thanks!

  • Pipeline finished with Failed
    3 days ago
    Total: 4862s
    #274638
  • ๐Ÿ‡ต๐Ÿ‡ญPhilippines binssss Bacoor Cavite

    Hi! We'll be reviewing this change today as a group; this is our first time contributing.

  • ๐Ÿ‡ต๐Ÿ‡ญPhilippines rduterte PH

    Hello, We're going to be testing this changes for our first contribution.

  • Pipeline finished with Success
    2 days ago
    Total: 545s
    #275376
  • ๐Ÿ‡ต๐Ÿ‡ญPhilippines binssss Bacoor Cavite
  • ๐Ÿ‡ต๐Ÿ‡ญPhilippines rduterte PH
  • Status changed to RTBC 2 days ago
  • ๐Ÿ‡ต๐Ÿ‡ญPhilippines rduterte PH
  • Status changed to Needs work 1 day ago
  • ๐Ÿ‡ซ๐Ÿ‡ทFrance nod_ Lille

    Thanks, better.
    We try our best to not use IDs in CSS, so have a look at how umami solves this issue and apply the same to Olivero/Claro.
    The problem happens also on Claro, so that needs fixing there as well.

  • Pipeline finished with Success
    1 day ago
    Total: 817s
    #275685
Production build 0.71.5 2024