- Issue created by @jaydeep.jdb@gmail.com
- Merge request !8879Spacing issue between Checkbox label and button has been fixed. โ (Open) created by jaydeep.jdb@gmail.com
- Issue was unassigned.
- Status changed to Needs review
about 2 months ago 2:29pm 22 July 2024 - ๐ฎ๐ณIndia jaydeep.jdb@gmail.com Ahmedabad
Spacing issue between Checkbox label and button has been fixed.
- Status changed to Needs work
about 2 months ago 3:09pm 22 July 2024 The Needs Review Queue Bot โ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- ๐ณ๐ฟNew Zealand quietone New Zealand
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
- Assigned to Yujiman85
- ๐บ๐ธUnited States Yujiman85
This looks like it needs a rebase so I can take care of that.
- Issue was unassigned.
- Status changed to Needs review
13 days ago 3:40pm 26 August 2024 Reviewed Issue is fixed.
Steps to reproduce.
1 : Fresh install Drupal 11 and use default Olivero theme.โจ
2 : Enable layout builder moduleโจ
3 : Use Layout Builder from Administration > Structure > Content types > Basic page > Manage display > default > layout optionsโจ
4 : Create Basic page from Content > Add content > Basic page and SaveโจStep5 : Click on Layout tab and you can find the spacing issue between Checkbox label and button.
5. Issue is fixed with give MR.- Status changed to RTBC
12 days ago 12:48pm 27 August 2024 - ๐บ๐ธUnited States smustgrave
Completed the issue summary.
Can confirm the issue on 11.x and that the MR addresses the problem.
- Status changed to Needs work
12 days ago 2:45pm 27 August 2024 - Status changed to Needs review
11 days ago 7:33pm 27 August 2024 - ๐บ๐ธUnited States Yujiman85
I moved the change into the Olivero theme and targeted the ID for that div. Needs a review.
As per previous comments changes are now moved to Olivero theme and targeted the ID for that div.
I can confirm on 11.x updated MR addresses the problem. https://www.drupal.org/project/drupal/issues/3463111#comment-15746322 ๐ Spacing issue between Checkbox label and button Needs reviewAdding screenshot for reference.
Steps to reproduce.
1 : Fresh install Drupal 11 and use default Olivero theme.โจ
2 : Enable layout builder moduleโจ
3 : Use Layout Builder from Administration > Structure > Content types > Basic page > Manage display > default > layout optionsโจ
4 : Create Basic page from Content > Add content > Basic page and SaveโจStep5 : Click on Layout tab and you can find the spacing issue between Checkbox label and button.
5. Issue is fixed with give MR.- ๐ฎ๐ณIndia sagarmohite0031
Hello
I have reproduced the issue for Spacing issue between Checkbox label and button on Drupal 11.
The MR is applied successfully.Steps to reproduce
Step1 : Fresh install Drupal 11 and use default Olivero theme.
Step2 : Enable layout builder module
Step3 : Use Layout Builder from Administration > Structure > Content types > Basic page > Manage display > default > layout options
Step4 : Create Basic page from Content > Add content > Basic page and Save
Step5 : Click on Layout tab and you can find the spacing issue between Checkbox label and button.See attached screen shot for reference.
Test Result:
Spacing issue between Checkbox label and button has been fixed.
Check attachments.RTBC+1
- Status changed to Needs work
7 days ago 6:08pm 31 August 2024 - ๐บ๐ธUnited States smustgrave
MR appears to have an issue.
FYI when making a css change have to edit the pcss first and recompile.
- Status changed to Needs review
3 days ago 12:43pm 5 September 2024 - ๐ฌ๐งUnited Kingdom rachel_norfolk UK
I've moved to Needs Review but I'll be leading some new contributors tomorrow through things and this would be a great one for them to check. Can you leave any review until at least the weekend? Thanks!
- ๐ต๐ญPhilippines binssss Bacoor Cavite
Hi! We'll be reviewing this change today as a group; this is our first time contributing.
- ๐ต๐ญPhilippines rduterte PH
Hello, We're going to be testing this changes for our first contribution.
- Status changed to RTBC
2 days ago 6:52am 6 September 2024 - Status changed to Needs work
1 day ago 12:46pm 6 September 2024 - ๐ซ๐ทFrance nod_ Lille
Thanks, better.
We try our best to not use IDs in CSS, so have a look at how umami solves this issue and apply the same to Olivero/Claro.
The problem happens also on Claro, so that needs fixing there as well.