- Issue created by @mikelutz
- Assigned to annmarysruthy
- Merge request !8924Fix issue #3462868: replace http with https in reference links โ (Open) created by annmarysruthy
- Issue was unassigned.
- ๐ฎ๐ณIndia annmarysruthy
annmarysruthy โ changed the visibility of the branch 3462868-replacehttp-1 to hidden.
- Status changed to Needs review
5 months ago 1:23pm 25 July 2024 - Status changed to Needs work
5 months ago 4:57pm 31 July 2024 - ๐บ๐ธUnited States smustgrave
Seems to be some missed one
views.theme.inc
breakpoint.module
breakpoint.overview.html.twigmaybe a few more.
- First commit to issue fork.
- Status changed to Needs review
5 months ago 11:40am 1 August 2024 - Status changed to Needs work
5 months ago 3:12pm 1 August 2024 - ๐ฎ๐ณIndia ankitv18
I found this reference http://www.w3.org in total 80 files and MR consists of changes in 52 files
Seems more files need to be taken care of. - Assigned to nexusnovaz
- ๐ฌ๐งUnited Kingdom nexusnovaz
Ill take a quick look and see if i can get the rest
- Issue was unassigned.
- Status changed to Needs review
5 months ago 2:32pm 3 August 2024 - ๐ฌ๐งUnited Kingdom nexusnovaz
Found two more files which matched the problem. There is one last file which is contained in ckeditor5-dll.js. As this wasn't a normal file, i've left that one to be discussed. There are another 100 matches however, those are xmlns references.
- ๐ฎ๐ณIndia ankitv18
Changes looks good but not sure whether we need to consider .twig .php files having http://www.w3.org (Within svg xmlns)
Attaching screenshot for your reference.
- Status changed to Needs work
5 months ago 5:02pm 3 August 2024 - ๐บ๐ธUnited States smustgrave
Also @ankitv18 please leave this for the newer users who were already working on it thanks
- ๐ฎ๐ณIndia ankitv18
@smustgrave, I just reviewed and synced the forked branch
- Assigned to yujiman85
- Issue was unassigned.
- Status changed to Needs review
4 months ago 2:19pm 16 August 2024 - ๐บ๐ธUnited States yujiman85
I wasn't sure if the .js files needed to be touched since those seemed compiled and minified. Please correct me if I'm wrong. This needs a review.
- Status changed to Needs work
4 months ago 12:22pm 20 August 2024 - ๐บ๐ธUnited States smustgrave
Welcome @Yujiman85 and nice work!
Appears to need a rebase now though. Will keep an eye out for your changes.
- ๐ณ๐ฟNew Zealand quietone
This is still a very large change. I am guessing a script is used to do this? Can it be shared?
- Status changed to Needs review
4 months ago 8:28pm 23 August 2024 - ๐บ๐ธUnited States yujiman85
@smustgrave Alright, I believe I did this right. I rebased the branch and it is up to date now with the commits from this branch. Needs a review.
- Status changed to Needs work
4 months ago 4:21am 1 September 2024 - ๐ฎ๐ณIndia ankitv18
Pipelines arenโt passing ~~ hence moving back into NW
- ๐ช๐ธSpain rodrigoaguilera Barcelona
I think this needs a rebase since the "/rebase" gitlab command fails. The current pipeline fail doesn't make sense to me
- ๐บ๐ธUnited States ultimike Florida, USA
I will be working on this issue during the DrupalCon Barcelona mentored contribution with @pierregermain
After September 28, 2024, feel free to pick this issue up and continue.
-mike
- First commit to issue fork.
- ๐ช๐ธSpain pierregermain
We reverted the last commit that was introducing changes to svg files that made the pipeline fail. After reverting the commit, the pipeline is passing again. Needs Review.
- ๐ฎ๐ชIreland lostcarpark
I have reviewed this issue and verified all the changes are to reference links, not XML or SVGs. All tests are passing.
Moving to RTBC.
-
quietone โ
committed 3359812d on 10.4.x
Issue #3462868 by annmarysruthy, yujiman85, nexusnovaz, pierregermain,...
-
quietone โ
committed 3359812d on 10.4.x
-
quietone โ
committed 9ba6f744 on 11.x
Issue #3462868 by annmarysruthy, yujiman85, nexusnovaz, pierregermain,...
-
quietone โ
committed 9ba6f744 on 11.x
- ๐ณ๐ฟNew Zealand quietone
I applied the diff and there are 4 occurrences, all of which are not to be modified.
git grep http://www.w3.org | grep -v .svg
- core/modules/media/tests/fixtures/example_1.jpeg:
- core/modules/media/tests/fixtures/example_2.jpeg:
- core/modules/navigation/tests/assets/image_test_files/test-logo.png:
- core/phpunit.xml.dist:
Committed and pushed to 11.x and 10.4.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.