Drupal 10 compatibility fixes/ update dependencies for PHP 8.x support

In PHP 8.1 i am getting error with composer install drupal/web_page_archive,
I update the php version in composer.json file please Review and test.

I don't feel like we should be supporting PHP7.x any more, it's well beyond EOL now, as is PHP8.0.

https://www.php.net/supported-versions.php

Thanks for your contribution @the_g_bomb.

When I try to enable the module, after applying your commits as a patch, I receive the error message below:

Class "Symfony\Component\EventDispatcher\Event" not found

Confirmed. I tried to get things in place, node etc to get the module fully working and ran into difficulties as well.

I have a fix in place locally and will push asap.

I suspect the fix I have in place may also fix: 🐛 Drupal 10 compatibility fixes Needs review

I have replaced
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
with
use Drupal\Component\EventDispatcher\EventSubscriberInterface;

Which should fix the issue you were facing @orkut-murat-yılmaz

I linked to https://www.drupal.org/project/drupal/issues/3055198 📌 [Symfony 5] Symfony/Component/EventDispatcher/Event is deprecated in Symfony 4.3 use Symfony/Contracts/EventDispatcher/Event instead Fixed in https://www.drupal.org/project/web_page_archive/issues/3446369#comment-1... 🐛 Drupal 10 compatibility fixes Needs review

This is the fix for the deprecation, I'm not sure why you both ignored my comment.

Also, you might want to drop support for D9 in this. I very much doubt this maintains compatibility.

Sorry, I didn't remove D9 support as I didn't think it was in the scope of the ticket, happy to update.

Also didn't ignore your comment, I did a find and replace on "Symfony\Component\EventDispatcher\" to replace it with "Drupal\Component\EventDispatcher\".

I must have missed that it replaced both Symfony\Component\EventDispatcher\Event as well as the instances of Symfony\Component\EventDispatcher\EventDispatcherInterface;

The Interfaces have been reverted.

I also removed D9 support and found another issue which I also fixed.

No need for sorry! D9 is unsupported now, so there's no need to accommodate "backwards-compatible" functionalities. I'm pretty sure we're breaking D9 compatibility with some of these changes anyway ... and with that in mind, my turn for a "sorry" - sorry ... but I think maybe I'm not being clear at all with my post above.

94x: Symfony\Component\EventDispatcher\Event is deprecated in drupal:9.1.0 and will be replaced by Symfony\Contracts\EventDispatcher\Event in drupal:10.0.0. A new Drupal\Component\EventDispatcher\Event class is available to bridge the two versions of the class. See https://www.drupal.org/node/3159012 →

There's no need to use \Drupal\Component\EventDispatcher\Event at all - if anything, it's more likely to be removed given it's bridging a deprecation for an older version of D9 (which as I say, is no longer supported by a VERY long way).

I was trying to say, don't use the Drupal one - you should just use the \Symfony\Contracts\EventDispatcher\Event class instead.

I misunderstood your comment #3 @pobster, but it is more clear for me now.

Done, thanks for the pointers.

@pobster, thanks for the merge:)

can we consider merging with the 4.1.1 release and publish it on the module project's page too?

best,
Orkut

can we consider merging with the 4.1.1 release and publish it on the module project's page too?

I've tagged it for 4.1.2, but no - I won't publish it on the modules project page. This module isn't supported anymore; it is marked as "Seeking new maintainer"/ "No further development" as I don't work for Rackspace anymore and have no interest in maintaining it.