- Issue created by @SKAUGHT
- 🇨🇦Canada SKAUGHT
UX/A11Y question?
- should we change the img to decorative (and remove alt).
- svg will be using 'aria-label' -- can we swap simply this to be 'hidden'? - Merge request !254Issue #3441586. Navigation logo does not communicate purpose of link → (Open) created by SKAUGHT
- Status changed to Needs review
8 months ago 4:22pm 17 April 2024 - 🇩🇪Germany rkoller Nürnberg, Germany
about the question should the logo be decorative or not. probably making the icon decorative might be the right step. www.tpgi.com and www.deque.com for example are using the alt attribute while the www.a11yproject.com is using the aria-hidden=true attribute for the logo. in case of tpgi and deque, those are both companies and they try to communicate that their company branding is in place here. but in the case of the navigation module knowing that there is an icon doesnt provide any extra benefit, to do it properly you would even have to describe it, that you are seeing a blueish rectangular button with rounded edges with a white drupal drop logo (since in this form it isnt used anywhere else). so making it decorative and focus on the link's purpose i might consider in the context of a navigation menu the better choice.
in regards of the label. going with just
Homepage
i am not sure if that is that clear. In the old admin toolbar you hadBack to site
. That made it clear that you are going somewhere entirely else. With homepage one might question are you going to/admin
or what does Homepage refer to?
Adding a detail that you are going to the landing page of your default theme in the front end might clarify things. So i wonder maybe go with something likeFrontpage default theme
orHomepage default theme
. That would include for one that you go to the frontpage/homepage and that it is the frontpage/homepage of the default theme. but "default theme" could also be too abstract in case the user is unaware of the concept of the default theme in drupal. as an alternative you could use the installed theme's name instead, but that could also throw off the user. Or even return to the label that was used in the admin toolbar and go withBack to site
or completely different option that was not raised yet? - 🇨🇦Canada SKAUGHT
IMO: 'default theme' info is too much info.. i understand the thought.
we have talked about toolbar and 'back to site' which itself has additional redirect logic (which others also thought is actually confusing as the landing point then is in consistant..).
'back to site': means nothing if you are already on the homepage, thus (as an english phrase) 'homepage' feels like it will work without having to dynamically change the title on . of course, hoping to avoid 'frontpage' (:
-> should we switch the title when on the path? maybe this is the problem. - Status changed to Needs work
8 months ago 10:44pm 26 April 2024 - 🇪🇸Spain ckrina Barcelona
Moving to Needs work after getting Navigation into core.
- First commit to issue fork.
- Status changed to Needs review
8 months ago 3:57am 10 May 2024 - Status changed to Needs work
7 months ago 1:23pm 13 May 2024 - 🇺🇸United States smustgrave
Think the MR needs to be opened.
Also feels like something we can add a test assertion somewhere to an existing test, if one exists know the tests are still WIP.
- Merge request !8059aria-hidden role and focusable attributes added → (Open) created by Unnamed author
- 🇮🇳India mithun s Bangalore
Mithun S → made their first commit to this issue’s fork.