- Issue created by @rkoller
- ๐จ๐ฆCanada mgifford Ottawa, Ontario
Thanks @rkoller. Thanks for documenting this all. It would be great to help make it easier to identify what elements are active. We can make this easier for everyone to identify.
- ๐ช๐ธSpain ckrina Barcelona
Hi @rkoller. First of all thank you for taking the time to work on this! We're working on a new design system that will change colors and, more important, states. More info in ๐ [META] Implement the final design system Fixed .
So I am postponing this until that one is ready. Sorry for not communicating this work in progress properly sooner! It's been complicated to coordinate all the moving parts to have them ready on time. - Status changed to Needs work
10 months ago 3:16pm 5 April 2024 - ๐บ๐ธUnited States KeyboardCowboy Denver, CO, USA
We'd like to review this against the new designs that are currently implemented as part of the Drawer system.
- ๐ช๐ธSpain ckrina Barcelona
Designs have been updated to comply with the accessibility requirements. Updating the issue summary accordingly.
- First commit to issue fork.
- Merge request !8446Issue #3426468: Make the active menu item visually stand out more โ (Open) created by Unnamed author
- Status changed to Needs review
7 months ago 1:33pm 18 June 2024 - ๐ฎ๐ณIndia mithun s Bangalore
Mithun S โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia mithun s Bangalore
Currently #00389a is used as (-admin-toolbar-color-blue-650) and #002566 is used as ( --admin-toolbar-color-blue-700). Hence introduced a new variable (--admin-toolbar-color-blue-670) for #002e9a and used the variables on css files. Please suggest if the variable name is good. If any changes that would be required, am happy to update the same.
Thank you! - ๐ฎ๐ณIndia ahsannazir
The hover styles on submenu child items are not as per the design shared above. Attaching sccreencapture
- Status changed to Needs work
7 months ago 6:38am 26 June 2024 - Status changed to Needs review
7 months ago 5:23am 3 July 2024 - Assigned to dishakatariya
- Issue was unassigned.
- Status changed to Needs work
7 months ago 3:56am 10 July 2024 - Status changed to Needs review
6 months ago 4:09am 1 August 2024 - ๐ช๐ธSpain ckrina Barcelona
This is a visual change, please add before and after screenshots so we can compare and see the results.
- Status changed to Needs work
6 months ago 12:01am 5 August 2024 - ๐บ๐ธUnited States smustgrave
per #20.
before/after should go into the user interface section of the summary.
- ๐ฎ๐ณIndia nayana_mvr
I just checked the latest changes in the MR8446. Changes are applied cleanly but I think there are more changes required. For eg., the Content menu font color in active state is still not updated. I think the current font color changes are not getting applied to menus such as Blocks, Content, Files and Help. Also, on hovering the menu the outline color is changing but but font color remains the same. I'm attaching few screenshots which shows the color code also in the styles for reference. As I'm unable to access the Figma desgn dev mode, I couldn't verify the exact color codes.