Visually-hidden refresh button in Field UI fails WCAG Focus Visible.

Tagging

I have added a custom class to take of all the things described in the remaining tasks.I was able to hit the breakpoint for

Cross-browser manual testing - Confirm the trigger('mousedown') in Drupal.fieldUIOverview.AJAXRefreshRows() still works, in all our supported browsers.

atleast in Chrome.
The failing test seems to be random failures as they are failing on 11.x as well(atleast on my local).Marking it as needs review just to get an initial round of review.

Hiding patches for clarity.

On a standard profile install of 11.x
Can confirm on /admin/structure/types/manage/article/form-display that tabbing through the page that focus is lost between the last gear icon and the "Save" button.

Applied the MR and focus no longer appears to be lost.

Solution of using a custom class also appears to be least disruptive in my opinion especially since it can be added this way. Wonder if there is other places this is also fixing.

Looks great to me!

Wrong tag

Reading the IS the problem is that keyboard focus is possible. tabindex="-1" would fix that, can someone confirm that it works? Adding a new class and a bunch of display:none in the CSS is not the way to go.

#28 seems to be a better approach, so I have reverted the class changes and added tabIndex to the button thus making it non tabbable.Also the mousedown trigger event is working so marking it as needs review again.Thanks!

need a small comment

Mithun S → made their first commit to this issue’s fork.

Added a rebase of the latest changes from the branch.
The MR looks mergable now. Thank you!

Feedback appears to be addressed.

@Mithun S thanks for the rebase but only needed if the MR is unmergable just an FYI.

nod_ → closed merge request !8174

Committed and pushed b97be27a89 to 11.x and 68a22a5cc0 to 11.0.x and 6e1e0c29d0 to 10.4.x and d0592e79ef to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.