- First commit to issue fork.
- Merge request !8174Added custom class to hide the refresh button for all users → (Closed) created by utkarsh_33
- Status changed to Needs review
7 months ago 6:38am 24 May 2024 I have added a custom class to take of all the things described in the remaining tasks.I was able to hit the breakpoint for
Cross-browser manual testing - Confirm the trigger('mousedown') in Drupal.fieldUIOverview.AJAXRefreshRows() still works, in all our supported browsers.
atleast in Chrome.
The failing test seems to be random failures as they are failing on 11.x as well(atleast on my local).Marking it as needs review just to get an initial round of review.- last update
7 months ago Composer error. Unable to continue. - Status changed to RTBC
7 months ago 9:11pm 5 June 2024 - 🇺🇸United States smustgrave
Hiding patches for clarity.
On a standard profile install of 11.x
Can confirm on /admin/structure/types/manage/article/form-display that tabbing through the page that focus is lost between the last gear icon and the "Save" button.Applied the MR and focus no longer appears to be lost.
Solution of using a custom class also appears to be least disruptive in my opinion especially since it can be added this way. Wonder if there is other places this is also fixing.
Looks great to me!
- Status changed to Needs work
6 months ago 7:51pm 13 June 2024 - 🇫🇷France nod_ Lille
Reading the IS the problem is that keyboard focus is possible.
tabindex="-1"would fix that, can someone confirm that it works? Adding a new class and a bunch of display:none in the CSS is not the way to go. - Status changed to Needs review
6 months ago 5:07am 18 June 2024 #28 seems to be a better approach, so I have reverted the class changes and added tabIndex to the button thus making it non tabbable.Also the mousedown trigger event is working so marking it as needs review again.Thanks!
- 🇮🇳India mithun s Bangalore
Mithun S → made their first commit to this issue’s fork.
- 🇮🇳India mithun s Bangalore
Added a rebase of the latest changes from the branch.
The MR looks mergable now. Thank you! - Status changed to RTBC
6 months ago 2:36pm 24 June 2024 - 🇺🇸United States smustgrave
Feedback appears to be addressed.
@Mithun S thanks for the rebase but only needed if the MR is unmergable just an FYI.
- Status changed to Fixed
6 months ago 3:20pm 24 June 2024 - 🇫🇷France nod_ Lille
Committed and pushed b97be27a89 to 11.x and 68a22a5cc0 to 11.0.x and 6e1e0c29d0 to 10.4.x and d0592e79ef to 10.3.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.