Contextual Links Style Update

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Gauravvvv → made their first commit to this issue’s fork.

Imo it should now definitely use floating UI lib. Which now in core.

MR has failures.

Did not review or test

Removing stable blocker because claro is marked stable
Removing NorthAmerica2021, Design4Drupal2021, Europe2021 as previous events this was worked on

#134 should be considered too or mentioned why not I think.

Mithun S → made their first commit to this issue’s fork.

yash.rode → made their first commit to this issue’s fork.

#3023322-134: Contextual Links Style Update → We cannot use floating UI lib, that is a functionality change and this is specifically for styling.

Tests are passing now. Ready for review.

Added some comments. Take a look.

Also please. Why MR modifies core/misc/jquery.form.js ?

Hi, I have addressed all the feedbacks but I am not sure about the style that was added to the SVG, I removed those for now and added stroke attribute, it is working same. So is that fine, or am I missing something here?

Can the issue summary be updated using the standard issue template please. As a UI fix would be super useful to have before/after screenshots as part of the summary.

Wonder if the "Needs followup" tag can be removed.

There's an open thread around the new function extend_library() which I believe was being used to deprecate a library but we have a mechanism for that now.

Thanks!

I still see imported variables in
core/themes/claro/css/theme/contextual.icons.theme.css
core/themes/claro/css/theme/contextual.theme.css

and some unexpected changes in core/themes/claro/css/theme/media-library.css

Addressed all the feedbacks in #145.
Regarding

and some unexpected changes in core/themes/claro/css/theme/media-library.css

the changes are made to make the pencil visible in high contrast setting of the browser.Before that it was styled using inline css.
For now I have removed the use of stroke and used fill.

Attaching the screenshots of the state when the stroke/fill is not used

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

As a UI change can the User section of the issue summary template be added back and screenshots be included.

Added standard IS template.