The Needs Review Queue Bot โ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- ๐ฎ๐ณIndia Gauravvv Delhi, India
Gauravvvv โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 2 months ago 4:13am 29 April 2024 - ๐ท๐ธSerbia finnsky
Imo it should now definitely use floating UI lib. Which now in core.
- Status changed to Needs work
about 2 months ago 1:23pm 29 April 2024 - ๐บ๐ธUnited States smustgrave
MR has failures.
Did not review or test
Removing stable blocker because claro is marked stable
Removing NorthAmerica2021, Design4Drupal2021, Europe2021 as previous events this was worked on#134 should be considered too or mentioned why not I think.
- ๐ฎ๐ณIndia Mithun S Bangalore
Mithun S โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia yash.rode pune
yash.rode โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia yash.rode pune
#3023322-134: Contextual Links Style Update โ We cannot use floating UI lib, that is a functionality change and this is specifically for styling.
- Status changed to Needs review
3 days ago 5:52am 24 June 2024 - Status changed to Needs work
2 days ago 7:09am 24 June 2024 - ๐ท๐ธSerbia finnsky
Added some comments. Take a look.
Also please. Why MR modifies core/misc/jquery.form.js ?
- Status changed to Needs review
about 9 hours ago 10:02am 26 June 2024 - ๐ฎ๐ณIndia yash.rode pune
Hi, I have addressed all the feedbacks but I am not sure about the style that was added to the SVG, I removed those for now and added stroke attribute, it is working same. So is that fine, or am I missing something here?