- Issue created by @shweta__sharma
- Merge request !6238drupal-3415776: Unset the background property. โ (Closed) created by shweta__sharma
- Status changed to Needs review
over 1 year ago 8:01am 19 January 2024 - ๐ฎ๐ณIndia sandeep_k New Delhi
@shweta__sharma, I've tested the shared MR- MR !6238 mergeable I was able to reproduce the issue but while applying the patch, I was getting an error & patch didn't apply. Error attached.
- Status changed to RTBC
over 1 year ago 2:08pm 19 January 2024 - ๐บ๐ธUnited States smustgrave
Seems like a small change and confirmed the issue.
- Status changed to Needs work
about 1 year ago 2:33pm 19 February 2024 - ๐บ๐ธUnited States mherchel Gainesville, FL, US
Let's not resort to
!important
unless it's absolutely necessary.A better fix would be to override the exact same selector (
.claro-details[open]>.claro-details__summary:focus::before,
) within the forced-colors media query. You could add this on line 292.
Note that the details.pcss.css file needs quite a bit of refactoring at some point. It doesn't make use of modern CSS, or nesting like many other Claro stylesheets do. But in the meantime, let's keep the stylesheet consistent and keep the same patterns.
- Status changed to Needs review
about 1 year ago 6:34am 22 February 2024 - ๐ฎ๐ณIndia mithun s Bangalore
Mithun S โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia mithun s Bangalore
Removed the unnecessary trailing comma in the css files and updated the PR with a commit.
- ๐ฎ๐ณIndia Kanchan Bhogade
Hi
I've tested the shared MR- MR !6238 mergeable I was able to reproduce the issue and the issue is fixed with the Patch.Attaching Screenshot
RTBC+1
- Status changed to RTBC
about 1 year ago 3:09pm 23 February 2024 - ๐บ๐ธUnited States smustgrave
Thanks @mhercel
Appears suggestions was implemented.
- Status changed to Fixed
about 1 year ago 9:53pm 29 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.