Add icon for entity synchronization

Hi krystalcode,

I am working on this and update you asap

Hi @krystalcode,

I have added reload icon as mentioned in the ticket. find the attached patch file and screenshot before and after patch implementation.

I'll review this one

Great work this does fix the issue.

But, when I enable the New Drupal Navigation, Test integration (experimental) admin toolbar the icon is gone again.

As far as I could see, this new experimental admin toolbar uses other classes.

.toolbar-icon-entity-sync-admin
becomes
.toolbar-link--entity-sync-admin

So I'd propose to also target that class as well, just to be future proof.

@selfirian

Can you provide complete steps that what you have done and what have you got issues.

Thanks

Thanks for working on this!

Are there any specs or instructions about the SVGs so that I can get one done for this module? The rebuild cache icon is kind of ok, but I use the font-awesome "refresh" for the standard admin toolbar because it has two arrows and the functionality of the module is syncing back-and-forth data between systems, while rebuild cache is in itself.

Moving this back to needs work as there are some conflicts in the MR and the SVG is missing

@selfirian

I have attched updated patch "icon-sync-3417911-3.patch". Kindly check and confirm.

Thanks

The patch does work as expected. Now it still uses the clear cache icon, for me that's fine. But @krystalcode was talking about using another icon... maybe that's worth investigating. Also @krystalcode could you add the icon to the svg?

@amitnar Could you turn the patch into a MR, as it's my understanding that doing MR is easier for the maintainers down the line. On a side note I had issues with the MR as well so I only tested the patch on latest dev.

Thanks for the good work!

MR needed, patch works though

@selfirian the SVB that I currently use might not fit in the specs/aesthetics of the Gin menu; it works for the standard admin toolbar. So my comment was more of a question:

Are there any specs or instructions about the SVGs so that I can get one done for this module?

@krystalcode that I don't know, maybe @saschaeggi can pitch in on that. You can check the #gin channel in slack...

Created a MR as per #15