Integrate with Layout Builder Iframe Modal

Created on 16 March 2023, almost 2 years ago
Updated 4 September 2024, 4 months ago

Layout Builder iFrame Modal allows to open some of the Layout Builder forms in modal instead of the sidebar which is much better for editors.

It has a "Custom routes" textarea to add arbitrary routes to open in iframe modal. Note that I raised a patch 🐛 Custom route to open in modal is restricted Needs review as despite this textarea, the routes filled in are not taken in account if these are contextual links.

As a lazy guy, I would like the "Manage attributes" contextual link to be listed as an option in the form instead of having to manually find and enter the route. The submitForm() of the form is flexible enough to simply save the key of the selected option. Using a form alter to add the "Manage attributes" route name will be enough to integrate with the module.

Feature request
Status

Needs review

Version

2.1

Component

Code

Created by

🇫🇷France vbouchet

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @vbouchet
  • Status changed to Needs review almost 2 years ago
  • 🇫🇷France vbouchet

    Forget the last patch, made a typo in the code. It won't work. Find a proper one.

  • 🇨🇿Czech Republic milos.kroulik

    I'm not sure why, but this seems to have no effect for me:

    • I've applied patch in this issue and also the one in https://www.drupal.org/project/layout_builder_iframe_modal/issues/3348594 🐛 Custom route to open in modal is restricted Needs review
    • I've enabled opening Manage block attributes route in the /modal at admin/config/content/layout_builder_iframe_modal
    • cleared the caches
    • it still opens in the offcanvas sidebar
    • added the route to the textarea manually to be really sure and cleared the cache again
    • it still opens in the offcanvas

    Did I miss anything?

Production build 0.71.5 2024