page-content component should allow for fluid container or responsive containers

Open on Drupal.org →

Created on 3 March 2024, 9 months ago

Updated 21 March 2024, 8 months ago

Bootstrap allows us to use different containers (https://getbootstrap.com/docs/5.3/layout/containers). But currently, page-content component twig template (https://git.drupalcode.org/project/radix/-/blob/6.0.x/components/page-co...) hardcodes the container class for page.header and page.content regions, which can be problematic e.g. when using the layout builder for the landing page layout.

I believe it makes sense to create a prop for this, which would allow fr any value supported by BS5 and "none", which would remove the wrapper div altogether.

I would like to work on this, but I'm not sure if I will be able to do this soon.

✨ Feature request

Status

Fixed

Version

6.0

Component

Code

Created by

🇨🇿Czech Republic milos.kroulik

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @milos.kroulik

Comment 8 months ago →

Hosisam → committed 7796e7f5 on 6.0.x

Issue #3425233: page-content component should allow for fluid container...

Comment 8 months ago →
hosisam
I have updated the page-content component to support responsive containers. Here is the updated documentation: https://doxigo.gitbook.io/radix/components/page-content
I'll update the page-footer as well.
Status changed to Fixed 8 months ago9:19am 7 March 2024
Comment 8 months ago →
hosisam
Comment 8 months ago →
🇨🇿Czech Republic milos.kroulik
Thanks a lot. Just today I learned that there are cases when no container should be set (https://getbootstrap.com/docs/5.3/layout/gutters/#no-gutters).
Comment 8 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024